feat(metrics_server): Add Bandit support#266
feat(metrics_server): Add Bandit support#266odarriba wants to merge 3 commits intoakoutmos:masterfrom
Conversation
|
@akoutmos I'm not surte if this lib is still maintained, just in case pinging you to see if we can get a review at some point 🙏 Thanks for your time and work for this lib 🙌 |
|
This code still generates a compiler warning because it refers to modules that may not be available. |
If you can test it again, now it should not emit any warning I think 🤔 |
|
I'm using my fork already at least until this project starts accepting PRs again. |
|
@akoutmos Any news on this? With this easy fix we will be solving compilation warnings on any new Phoenix app that uses Bandit by default 🙏 |
Change description
Updaters the metrics server child spec to support Bandit if available, as it is the new standard in Phoenix.
What problem does this solve?
It solves the need of exposing metrics in an internal port while using Bandit as the Plug server in newer/updated Phoenix apps.
Related issues: #265
Example usage
Additional details and screenshots
Screenshot of the standalone metrics server starting with Bandit:
Checklist