Add configurable Phoenix HTTP metric tags#284
Open
pepicrft wants to merge 1 commit intoakoutmos:masterfrom
Open
Add configurable Phoenix HTTP metric tags#284pepicrft wants to merge 1 commit intoakoutmos:masterfrom
pepicrft wants to merge 1 commit intoakoutmos:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
http_metrics_tagsconfiguration toPromEx.Plugins.Phoenixstatuswith groupedstatus_classstatus_class, and invalid tag validationWhy
The current Phoenix plugin always emits the full HTTP label set:
statusmethodpathcontrolleractionhostThat is a sensible default, but some deployments need to trade label richness for lower cardinality without copying the plugin downstream.
This change makes the HTTP tags configurable while preserving the current default behavior. It also adds
status_classas an opt-in replacement for exactstatus, which is useful when users want to keep route-level visibility but reduce the series explosion caused by per-code status labels.Example configuration:
Validation
mise exec elixir@1.18.2-otp-27 erlang@27.2.1 -- mix test test/prom_ex/plugins/phoenix_test.exs test/prom_ex/plugins/phoenix_multi_router_test.exs