Skip to content

Add System / RouterBOARD metrics#306

Closed
clau-bucur wants to merge 1 commit into
akpw:mainfrom
clau-bucur:main
Closed

Add System / RouterBOARD metrics#306
clau-bucur wants to merge 1 commit into
akpw:mainfrom
clau-bucur:main

Conversation

@clau-bucur

Copy link
Copy Markdown
Contributor

Allows to detect current firmware version and whether firmware upgrade is required.

Allows to detect current firmware version and whether firmware upgrade is required.
@akpw

akpw commented Mar 18, 2026

Copy link
Copy Markdown
Owner

@clau-bucur thanks for the PR, a few comments:

  • FE_ROUTERBOARD_KEY = True by default is problematic, both because of general backward-compatibility policy and because of the specific issues it would create for CHR / non-RouterBOARD devices. that would likely turn into noisy per-scrape error logging unless users manually disable the feature
  • there should be a configuration template update in mktxp/cli/config/mktxp.conf
  • there should be a configuration template update in deploy/kubernetes/secret.yaml
  • a dedicated test would be great, feel free to review the existing ones to see if you can add one

akpw added a commit that referenced this pull request May 10, 2026
@akpw akpw closed this May 10, 2026
@akpw

akpw commented May 10, 2026

Copy link
Copy Markdown
Owner

finished by 18a6d32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants