Skip to content

[FIX] Allow partial delivery even with mandatory inspections #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
florian-dacosta wants to merge 1 commit into
base: 18-imp-inspection_mandatory_on_picking
Choose a base branch
from
Open

[FIX] Allow partial delivery even with mandatory inspections #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions quality_control_stock_oca/models/stock_picking.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,22 @@ class StockPicking(models.Model):
readonly=True, compute="_compute_inspection_required_message"
)

@api.depends("qc_inspections_ids")
@api.depends("qc_inspections_ids", "move_ids.quantity", "move_ids.picked")
def _compute_inspection_required_message(self):
message = _("Control quality is required to validate this " "Transfert.")
for rec in self:
# in case of partial transfer, we want to check only the mandatory
# inspections related to what we are about to transfer
picked_moves = rec.move_ids.filtered(lambda m: m.picked)
if not picked_moves:
picked_moves = rec.move_ids.filtered(lambda m: m.quantity > 0)
if rec.qc_inspections_ids and rec.qc_inspections_ids.filtered(
lambda x: x.state not in ["success", "failed"]
lambda x, moves=picked_moves: x.state not in ["success", "failed"]
and x.is_mandatory_to_validate
and (
x.object_id._name == "stock.picking"
or (x.object_id._name == "stock.move" and x.object_id in moves)
)
):
rec.inspection_required_message = message
else:
Expand Down