Open
Conversation
Member
Author
|
@florian-dacosta you made a partial fix in 22e9234#diff-65eab62cb95fc45bce25d2c5ac761b99443b842eba90897de4c840d3aa43e2cf and that's why my PR now has a conflict. But I believe your fix was incomplete: indeed if you read my explanations in this PR, in OCB (at least on v12) the journal_id condition added by account_usability will simply be missed. What do you think? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See comments in the diff
cc @alexis-via (we talked about that on Framateam) @sebastienbeau