✨ Add feel,relh RWIS alldata storage

[akrherz]

supporting akrherz/iem#1130

[gemini-code-assist]

Hello @akrherz, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request adds support for storing feel (feels like temperature) and relh (relative humidity) data in the alldata table for the RWIS (Road Weather Information System) data within the IEM (Iowa Environmental Mesonet) system. This involves modifying the database schema to include these new fields and updating the schema version. The PR addresses issue akrherz/iem#1130.

Highlights

• Schema Update: The iem_schema_manager_version table is updated from version 7 to 8 in init/rwis.sql.
• alldata Table Modification: The alldata table in init/rwis.sql is altered to include feel and relh columns of type real.
• Upgrade Script: A new upgrade script upgrade/rwis/8.sql is added to alter the existing alldata table to include the new feel and relh columns.

Changelog

• init/rwis.sql
  • Updated iem_schema_manager_version from 7 to 8.
  • Modified the alldata table to include feel and relh columns of type real.
• upgrade/rwis/8.sql
  • Added a new upgrade script to alter the existing alldata table and add feel and relh columns.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

---

The database evolves, a schema's plight,
Adding fields to store the data right.
Feel and relh, now part of the core,
Weather's story, forevermore.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[deepsource-io]

Here's the code health analysis summary for commits 4f575ef..ca6cb89. View details on DeepSource ↗.

Analysis Summary

Analyzer	Status	Summary	Link
SQL	❌ Failure	❗ 45 occurences introduced 🎯 44 occurences resolved	View Check ↗
Python	✅ Success		View Check ↗

---

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

[gemini-code-assist]

Code Review

The pull request adds support for storing feel and relh (relative humidity) data in the alldata table for the RWIS (Road Weather Information System) database. The changes include updating the database schema, adding new columns to the alldata table, and creating an upgrade script. Overall, the changes seem reasonable and necessary for supporting the new data. However, there are a few points that could be improved.

Summary of Findings

• Schema Versioning: The schema version is incremented in init/rwis.sql. Ensure that the schema_manager.py script correctly uses this version to apply upgrades.
• Upgrade Script: The upgrade script upgrade/rwis/8.sql adds the new columns. Verify that this script is idempotent and handles potential errors during execution.
• Data Migration: Consider if any data migration is needed for existing data. If so, an additional upgrade script might be necessary.

Assessment

The pull request introduces new functionality by adding feel and relh data storage. The code changes seem to be logically sound and address the intended purpose. However, I recommend addressing the review comments to ensure the robustness and maintainability of the changes. After addressing the comments, another review by someone else is recommended before merging.