🐛 Address schema issues found with new testing

[akrherz]

No description provided.

[gemini-code-assist]

Hello @akrherz, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request addresses schema issues identified through new testing. The changes involve updating the iem.sql, other.sql, and postgis.sql files. Specifically, it grants permissions and sets ownership for the rwis_traffic_sensors and rwis_traffic_meta tables/views in iem.sql, creates new tables flux_meta and flux_vars in other.sql with appropriate ownership and permissions, and sets ownership and grants permissions for the robins table in postgis.sql.

Highlights

• Permissions: The pull request grants select permissions to nobody on rwis_traffic_sensors, rwis_traffic_meta, and robins tables/views.
• Ownership: The pull request sets the owner of rwis_traffic_sensors, flux_meta, flux_vars, and robins tables to mesonet.
• New Tables: The pull request creates two new tables, flux_meta and flux_vars, in the other.sql file to store metadata and variable information related to flux data.

Changelog

Click here to see the changelog

• init/iem.sql
  • Adds alter table statement to set owner of rwis_traffic_sensors to mesonet.
  • Adds grant select statement to grant select permission on rwis_traffic_sensors to nobody.
  • Adds grant select statement to grant select permission on rwis_traffic_meta to nobody.
• init/other.sql
  • Creates new table flux_meta with columns station, surface, sts, and ets.
  • Sets owner of flux_meta to mesonet.
  • Grants select permission on flux_meta to nobody.
  • Creates new table flux_vars with columns name, units, and details.
  • Sets owner of flux_vars to mesonet.
  • Grants select permission on flux_vars to nobody.
• init/postgis.sql
  • Adds alter table statement to set owner of robins to mesonet.
  • Adds grant select statement to grant select permission on robins to nobody.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

---

Trivia time!

What is PostGIS and what is it used for?

Click here for the answer

PostGIS is a spatial database extender for PostgreSQL. It adds support for geographic objects, allowing location queries to be run in SQL.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[deepsource-io]

Here's the code health analysis summary for commits e3a7166..9ade75c. View details on DeepSource ↗.

Analysis Summary

Analyzer	Status	Summary	Link
SQL	❌ Failure	❗ 158 occurences introduced 🎯 134 occurences resolved	View Check ↗
Python	✅ Success		View Check ↗

---

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

[gemini-code-assist]

Code Review

The pull request addresses schema issues by adding owner and grant permissions to several tables and views. Overall, the changes seem reasonable and necessary for maintaining proper database security and access control. However, there are a few points that could be improved for consistency and clarity.

Summary of Findings

• Inconsistent application of owner and grant permissions: The pull request adds owner and grant permissions to some tables and views but not all. It's important to ensure that these permissions are consistently applied across the entire schema to maintain a uniform security policy. I have only commented on the inconsistencies found at the high severity level, but there may be others.

Merge Readiness

The pull request introduces important schema changes that appear to address existing issues. However, due to the high severity issue regarding inconsistent application of owner and grant permissions, I recommend that these issues be addressed before merging. I am unable to directly approve this pull request, and other reviewers should also examine the changes before a merge occurs.