Fix perms

[akrherz]

No description provided.

[gemini-code-assist]

Hello @akrherz, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request focuses on two main areas: updating the ruff pre-commit hook version and modifying the nexrad_n0r_tindex and nexrad_n0q_tindex tables in init/postgis.sql. The ruff update involves bumping the version from v0.9.7 to v0.9.9 in the .pre-commit-config.yaml file. The changes to init/postgis.sql include adding a the_geom column of type geometry(MultiPolygon, 4326) to both nexrad_n0r_tindex and nexrad_n0q_tindex tables, altering the table owner to mesonet, and granting all privileges to ldm.

Highlights

• Ruff Version Update: The pull request updates the ruff pre-commit hook version in .pre-commit-config.yaml from v0.9.7 to v0.9.9.
• Schema Modification: The pull request modifies the nexrad_n0r_tindex and nexrad_n0q_tindex tables in init/postgis.sql by adding a the_geom column, altering the table owner, and granting privileges.

Changelog

• .pre-commit-config.yaml
  • Updated ruff pre-commit hook version from v0.9.7 to v0.9.9.
• init/postgis.sql
  • Added the_geom column of type geometry(MultiPolygon, 4326) to the nexrad_n0r_tindex table on line 956.
  • Altered the owner of the nexrad_n0r_tindex table to mesonet on line 958.
  • Granted all privileges on the nexrad_n0r_tindex table to ldm on line 959.
  • Added the_geom column of type geometry(MultiPolygon, 4326) to the nexrad_n0q_tindex table on line 971.
  • Altered the owner of the nexrad_n0q_tindex table to mesonet on line 973.
  • Granted all privileges on the nexrad_n0q_tindex table to ldm on line 974.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

---

Trivia time!

What is PostGIS and what is it used for?

Click here for the answer

PostGIS is a spatial database extender for PostgreSQL. It adds support for geographic objects, allowing location queries to be run in SQL.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[deepsource-io]

Here's the code health analysis summary for commits 0157e16..833c010. View details on DeepSource ↗.

Analysis Summary

Analyzer	Status	Summary	Link
SQL	✅ Success		View Check ↗
Python	✅ Success		View Check ↗

---

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

[gemini-code-assist]

Code Review

The pull request addresses permission issues and updates a dependency. The changes to the SQL scripts add a geometry column and modify ownership/permissions for two tables. The update to the pre-commit config updates the ruff version.

Summary of Findings

• Potential data loss in nexrad_n0r_tindex and nexrad_n0q_tindex tables: Adding a the_geom column to existing tables without a DEFAULT clause can result in NULL values for existing rows. This could lead to data loss or unexpected behavior if the application relies on this column being populated. Consider adding a default value or backfilling the data.

Merge Readiness

The pull request includes important permission fixes and a dependency update. However, the potential data loss issue in the SQL scripts should be addressed before merging. I am unable to directly approve this pull request, so please have another reviewer approve this code before merging.

[gemini-code-assist]

Adding a the_geom column without a DEFAULT clause will result in NULL values for existing rows. This could lead to data loss or unexpected behavior if the application relies on this column being populated. Consider adding a default value or backfilling the data. Also, the geometry type is MultiPolygon, but the AddGeometryColumn function is not being used here, which was used in the original table creation in line 957 before the diff. Should we be using that function instead to ensure the geometry column is properly added?

 filepath varchar,
 the_geom geometry(MultiPolygon, 4326) DEFAULT ST_GeomFromText('MULTIPOLYGON EMPTY', 4326)
 );

[gemini-code-assist]

Adding a the_geom column without a DEFAULT clause will result in NULL values for existing rows. This could lead to data loss or unexpected behavior if the application relies on this column being populated. Consider adding a default value or backfilling the data. Also, the geometry type is MultiPolygon, but the AddGeometryColumn function is not being used here, which was used in the original table creation in line 970 before the diff. Should we be using that function instead to ensure the geometry column is properly added?

 filepath varchar,
 the_geom geometry(MultiPolygon, 4326) DEFAULT ST_GeomFromText('MULTIPOLYGON EMPTY', 4326)
 );