Feature/kafka mode threat guardrails #3768

notshivansh · 2025-12-15T11:28:59Z

No description provided.

devsecopsbot

🤖 AI Security analysis: "A medium-severity path traversal issue exists in apps/guardrails-service/container/src/pkg/kafka/consumer.go, risking unauthorized file access when consumer code uses user-controlled paths without proper sanitization."

Risk Level	AI Score
🟢 LOW	35.0/100

Top 1 security issues / 1 total (Critical: 0, High: 0, Medium: 1, Low: 0)

Title	Location	Recommendation
Path Traversal	`apps/guardrails-service/container/src/pkg/kafka/consumer.go:184`	Use filepath.Base to only use the filename and not path information. Always validate the…

🔗 View Detailed Report

apps/guardrails-service/container/src/pkg/kafka/consumer.go

rakshak-akto · 2025-12-15T11:57:35Z

apps/guardrails-service/container/src/.cursor/rules/agent-guard-ruleset.mdc

@@ -0,0 +1,5 @@
+---


gitignore .cursor files

Adding rules for everyone.

rakshak-akto · 2025-12-15T12:07:56Z

apps/guardrails-service/container/src/pkg/validator/service.go

+			zap.Int("policiesCount", len(policies)))
+		return policies, auditPolicies, compiledRules, hasAuditRules, nil
+	}
+	s.cache.mu.RUnlock()


Can add a comment to highlight the criticality of this line to avoid deadlock since the regular defer unlock way won't work here.

rakshak-akto · 2025-12-15T12:38:58Z

apps/guardrails-service/container/src/main.go

-	config := zap.NewProductionConfig()
+	config := zap.NewDevelopmentConfig()
 	config.Level = zap.NewAtomicLevelAt(level)
-	config.EncoderConfig.TimeKey = "timestamp"
-	config.EncoderConfig.EncodeTime = zapcore.ISO8601TimeEncoder
+	config.EncoderConfig.EncodeTime = zapcore.TimeEncoderOfLayout("2006-01-02 15:04:05")
+	config.EncoderConfig.EncodeLevel = zapcore.CapitalColorLevelEncoder


Were the logs not readable before?

they were in JSON, this is single line text, slightly more convenient

rakshak-akto · 2025-12-15T12:44:07Z

apps/guardrails-service/container/src/main.go

+	}
+	defer consumer.Close()
+
+	ctx := context.Background()


ctx, stop := signal.NotifyContext(context.Background(), os.Interrupt, syscall.SIGTERM) defer stop()

The sigTerm handling is present inside the Start function.
So adding here will be redundant.

rakshak-akto · 2025-12-15T12:58:28Z

apps/guardrails-service/container/src/pkg/kafka/consumer.go

+			if err != nil {
+				if errors.Is(err, context.DeadlineExceeded) {
+					// Timeout is expected when no messages available, continue silently
+					continue
+				}
+				if errors.Is(err, context.Canceled) {
+					return nil
+				}
+				c.logger.Error("Failed to read message from Kafka", zap.Error(err))
+				continue
+			}


Can add more error scenarios

if ctx.Err() != nil { // parent context canceled return nil } if errors.Is(err, context.DeadlineExceeded) { continue } if errors.Is(err, context.Canceled) { return nil } if errors.Is(err, io.EOF) { // kafka-go errors return nil }

devsecopsbot

🤖 AI Security analysis: "A medium-severity path traversal issue exists in apps/guardrails-service/container/src/pkg/kafka/consumer.go, risking unauthorized file access when consumer code uses user-controlled paths without proper sanitization."

Risk Level	AI Score
🟢 LOW	35.0/100

Top 1 security issues / 1 total (Critical: 0, High: 0, Medium: 1, Low: 0)

Title	Location	Recommendation
Path Traversal	`apps/guardrails-service/container/src/pkg/kafka/consumer.go:185`	Use filepath.Base to only use the filename and not path information. Always validate the…

🔗 View Detailed Report

apps/guardrails-service/container/src/pkg/kafka/consumer.go

Co-authored-by: devsecopsbot[bot] <177726887+devsecopsbot[bot]@users.noreply.github.com>

devsecopsbot

🤖 AI Security analysis: "A medium-severity path traversal issue exists in apps/guardrails-service/container/src/pkg/kafka/consumer.go, risking unauthorized file access when consumer code uses user-controlled paths without proper sanitization."

Risk Level	AI Score
🟢 LOW	35.0/100

Top 1 security issues / 1 total (Critical: 0, High: 0, Medium: 1, Low: 0)

Title	Location	Recommendation
Path Traversal	`apps/guardrails-service/container/src/pkg/kafka/consumer.go:191`	Use filepath.Base to only use the filename and not path information. Always validate the…

🔗 View Detailed Report

apps/guardrails-service/container/src/pkg/kafka/consumer.go

devsecopsbot

🤖 AI Security analysis: "A medium-severity path traversal issue exists in apps/guardrails-service/container/src/pkg/kafka/consumer.go, risking unauthorized file access when consumer code uses user-controlled paths without proper sanitization."

Risk Level	AI Score
🟢 LOW	35.0/100

Top 1 security issues / 1 total (Critical: 0, High: 0, Medium: 1, Low: 0)

Title	Location	Recommendation
Path Traversal	`apps/guardrails-service/container/src/pkg/kafka/consumer.go:193`	Use filepath.Base to only use the filename and not path information. Always validate the…

🔗 View Detailed Report

apps/guardrails-service/container/src/pkg/kafka/consumer.go

Co-authored-by: devsecopsbot[bot] <177726887+devsecopsbot[bot]@users.noreply.github.com>

devsecopsbot

🤖 AI Security analysis: "A medium-severity path traversal issue exists in apps/guardrails-service/container/src/pkg/kafka/consumer.go, risking unauthorized file access when consumer code uses user-controlled paths without proper sanitization."

Risk Level	AI Score
🟢 LOW	35.0/100

Top 1 security issues / 1 total (Critical: 0, High: 0, Medium: 1, Low: 0)

Title	Location	Recommendation
Path Traversal	`apps/guardrails-service/container/src/pkg/kafka/consumer.go:199`	Use filepath.Base to only use the filename and not path information. Always validate the…

🔗 View Detailed Report

apps/guardrails-service/container/src/pkg/kafka/consumer.go

devsecopsbot

🤖 AI Security analysis: "A medium-severity path traversal issue exists in apps/guardrails-service/container/src/pkg/kafka/consumer.go, risking unauthorized file access when consumer code uses user-controlled paths without proper sanitization."

Risk Level	AI Score
🟢 LOW	35.0/100

Top 1 security issues / 1 total (Critical: 0, High: 0, Medium: 1, Low: 0)

Title	Location	Recommendation
Path Traversal	`apps/guardrails-service/container/src/pkg/kafka/consumer.go:184`	Use filepath.Base to only use the filename and not path information. Always validate the…

🔗 View Detailed Report

apps/guardrails-service/container/src/pkg/kafka/consumer.go

devsecopsbot

🤖 AI Security analysis: "Hard-coded AWS secret in .github/workflows/prod.yml risks credential exposure and account compromise. Medium risks include a path traversal in the Kafka consumer (arbitrary file reads) and workflow_dispatch inputs that allow user-influenced build output, creating a supply-chain risk."

Risk Level	AI Score
🔴 CRITICAL	85.0/100

Top 4 security issues / 4 total (Critical: 0, High: 1, Medium: 2, Low: 1)

Title	Location	Recommendation
Hard-coded AWS secret access key	`.github/workflows/prod.yml:309`	Replace the hard-coded secret access key with AWS role assumption and temporary OIDC secu…
Path Traversal	`apps/guardrails-service/container/src/pkg/kafka/consumer.go:184`	Use filepath.Base to only use the filename and not path information. Always validate the…
The build output cannot be affected by user parameters other than the build ent…	`.github/workflows/prod.yml:8`	The build output cannot be affected by user parameters other than the build entry point a…
Deprecated ::set-output workflow command	`.github/workflows/prod.yml:301`	Replace ::set-output with the GITHUB_STATE environment file.

🔗 View Detailed Report

devsecopsbot · 2025-12-16T18:55:17Z

.github/workflows/prod.yml

+          docker buildx build --platform linux/arm64/v8,linux/amd64 -t $ECR_REGISTRY/guardrails-service:local -t $ECR_REGISTRY/guardrails-service:$IMAGE_VERSION . --push
+          echo "::set-output name=image::$ECR_REGISTRY/guardrails-service:$IMAGE_VERSION"
+
+      - name: Configure AWS Credentials for ECR


Suggested change

- name: Configure AWS Credentials for ECR

- name: Configure AWS Credentials for ECR

uses: aws-actions/configure-aws-credentials@v2

with:

role-to-assume: ${{ secrets.AWS_OIDC_ROLE_ARN }}

aws-region: us-east-1

🟠 HIGH: Hard-coded AWS secret access key
Replace long-lived access key usage with OIDC-based role assumption (aws-actions/configure-aws-credentials v2). This avoids storing long-term AWS secrets in the repo and uses short-lived credentials via an IAM role (set AWS_OIDC_ROLE_ARN in repo secrets and configure the role trust for GitHub OIDC).

devsecopsbot · 2025-12-16T18:55:17Z

.github/workflows/prod.yml

+        run: |
+          docker buildx create --use
+          cd apps/guardrails-service/container
+          docker buildx build --platform linux/arm64/v8,linux/amd64 -t $ECR_REGISTRY/guardrails-service:local -t $ECR_REGISTRY/guardrails-service:$IMAGE_VERSION . --push


Suggested change

docker buildx build --platform linux/arm64/v8,linux/amd64 -t $ECR_REGISTRY/guardrails-service:local -t $ECR_REGISTRY/guardrails-service:$IMAGE_VERSION . --push

echo "image=$ECR_REGISTRY/guardrails-service:$IMAGE_VERSION" >> $GITHUB_OUTPUT

🟢 LOW: Deprecated ::set-output workflow command
The ::set-output command is deprecated. Write the output to the GITHUB_OUTPUT file to set the step output (preserves the same step id output 'image').

devsecopsbot · 2025-12-16T18:55:17Z

apps/guardrails-service/container/src/pkg/kafka/consumer.go

+			InsecureSkipVerify: os.Getenv("KAFKA_INSECURE_SKIP_VERIFY") == "true",
+			MinVersion:         tls.VersionTLS12,
+		}, nil
+	}


Suggested change

}

// Sanitize path to prevent path traversal: use only the filename and force local path

if tlsCACertPath != "" {

if i := strings.LastIndexAny(tlsCACertPath, "/\\"); i != -1 {

tlsCACertPath = tlsCACertPath[i+1:]

}

// Ensure we always use a local relative path (avoid absolute paths)

tlsCACertPath = "./" + strings.TrimLeft(tlsCACertPath, "/\\")

}

🟡 MEDIUM: Path Traversal
Prevent path traversal by stripping any directory components from KAFKA_TLS_CA_CERT_PATH and forcing a local relative path. This avoids using attacker-controlled paths (e.g., ../../etc/passwd) when reading the CA file without adding new imports.

notshivansh added 2 commits December 15, 2025 16:19

add support for kafka

dab60bc

add policy cache and traffic filters

68aa0ac

devsecopsbot bot reviewed Dec 15, 2025

View reviewed changes

apps/guardrails-service/container/src/pkg/kafka/consumer.go Outdated Show resolved Hide resolved

rakshak-akto previously approved these changes Dec 15, 2025

View reviewed changes

notshivansh added 2 commits December 16, 2025 23:26

Merge branch 'master' into feature/kafka_mode_threat_guardrails

739acb2

add comment and more kafka cases.

86b99a6

notshivansh dismissed rakshak-akto’s stale review via 86b99a6 December 16, 2025 18:23

devsecopsbot bot reviewed Dec 16, 2025

View reviewed changes

apps/guardrails-service/container/src/pkg/kafka/consumer.go Outdated Show resolved Hide resolved

Update apps/guardrails-service/container/src/pkg/kafka/consumer.go

07d6a06

Co-authored-by: devsecopsbot[bot] <177726887+devsecopsbot[bot]@users.noreply.github.com>

devsecopsbot bot reviewed Dec 16, 2025

View reviewed changes

apps/guardrails-service/container/src/pkg/kafka/consumer.go Outdated Show resolved Hide resolved

tidy

e7c3034

devsecopsbot bot reviewed Dec 16, 2025

View reviewed changes

apps/guardrails-service/container/src/pkg/kafka/consumer.go Outdated Show resolved Hide resolved

Update apps/guardrails-service/container/src/pkg/kafka/consumer.go

0d3ba02

Co-authored-by: devsecopsbot[bot] <177726887+devsecopsbot[bot]@users.noreply.github.com>

devsecopsbot bot reviewed Dec 16, 2025

View reviewed changes

apps/guardrails-service/container/src/pkg/kafka/consumer.go Outdated Show resolved Hide resolved

skip verification, internal module

e1a4752

devsecopsbot bot reviewed Dec 16, 2025

View reviewed changes

apps/guardrails-service/container/src/pkg/kafka/consumer.go Show resolved Hide resolved

add builds

fc92ca5

devsecopsbot bot reviewed Dec 16, 2025

View reviewed changes

-      - name: Configure AWS Credentials for ECR
+- name: Configure AWS Credentials for ECR
+  uses: aws-actions/configure-aws-credentials@v2
+  with:
+    role-to-assume: ${{ secrets.AWS_OIDC_ROLE_ARN }}
+    aws-region: us-east-1

	docker buildx build --platform linux/arm64/v8,linux/amd64 -t $ECR_REGISTRY/guardrails-service:local -t $ECR_REGISTRY/guardrails-service:$IMAGE_VERSION . --push
	echo "image=$ECR_REGISTRY/guardrails-service:$IMAGE_VERSION" >> $GITHUB_OUTPUT

-	}
+// Sanitize path to prevent path traversal: use only the filename and force local path
+if tlsCACertPath != "" {
+	if i := strings.LastIndexAny(tlsCACertPath, "/\\"); i != -1 {
+		tlsCACertPath = tlsCACertPath[i+1:]
+	}
+	// Ensure we always use a local relative path (avoid absolute paths)
+	tlsCACertPath = "./" + strings.TrimLeft(tlsCACertPath, "/\\")
+}

Feature/kafka mode threat guardrails #3768

Are you sure you want to change the base?

Feature/kafka mode threat guardrails #3768

Uh oh!

Conversation

notshivansh commented Dec 15, 2025

Uh oh!

devsecopsbot bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

devsecopsbot bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

devsecopsbot bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

devsecopsbot bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

devsecopsbot bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

devsecopsbot bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

devsecopsbot bot left a comment

Choose a reason for hiding this comment

Uh oh!

devsecopsbot bot Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

devsecopsbot bot Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

devsecopsbot bot Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants