Skip to content

Conversation

@Marvin9
Copy link
Contributor

@Marvin9 Marvin9 commented Nov 19, 2025

Signed-off-by: Mayursinh Sarvaiya <[email protected]>
Signed-off-by: Mayursinh Sarvaiya <[email protected]>
@Marvin9 Marvin9 added this to the v1.9.0 milestone Nov 19, 2025
@Marvin9 Marvin9 self-assigned this Nov 19, 2025
@Marvin9 Marvin9 requested a review from a team as a code owner November 19, 2025 12:01
@Marvin9 Marvin9 added the kind/enhancement An entirely new feature label Nov 19, 2025
@Marvin9 Marvin9 requested a review from a team as a code owner November 19, 2025 12:01
@Marvin9 Marvin9 added area/ui Affects the UI priority/normal This is the priority for most work area/api-server Affects Kargo's API server labels Nov 19, 2025
@netlify
Copy link

netlify bot commented Nov 19, 2025

Deploy Preview for docs-kargo-io ready!

Name Link
🔨 Latest commit 69c481c
🔍 Latest deploy log https://app.netlify.com/projects/docs-kargo-io/deploys/691db17e0cf96200081aa100
😎 Deploy Preview https://deploy-preview-5404.docs.kargo.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Nov 19, 2025

Codecov Report

❌ Patch coverage is 55.00000% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.09%. Comparing base (913032d) to head (69c481c).

Files with missing lines Patch % Lines
pkg/server/create_credentials_v1alpha1.go 64.70% 4 Missing and 2 partials ⚠️
pkg/server/update_credentials_v1alpha1.go 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5404      +/-   ##
==========================================
- Coverage   56.10%   56.09%   -0.01%     
==========================================
  Files         411      411              
  Lines       30063    30077      +14     
==========================================
+ Hits        16868    16873       +5     
- Misses      12221    12227       +6     
- Partials      974      977       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

string username = 6;
// password is the password or token for authentication.
string password = 7;
string ssh_private_key = 9;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to eventually support GitHub App Authentication. Which has the fields:

  • githubAppClientID
  • githubAppPrivateKey
  • githubAppInstallationID

Is continually expanding CreateCredentialsRequest API the sustainable approach to this?

Should UI switch to the Apply endpoint and just create Secret resources with baked-in understanding of the various fields (username/password/privatekey/githubXXXX/etc...)? Then the ConnectRPC API layer never needs to updated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh. I thought its only sshPrivateKey. You are right, we should start using generic secrets.

Are you suggesting is to remove CreateCredentials approach? even for normal credentials?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/api-server Affects Kargo's API server area/ui Affects the UI kind/enhancement An entirely new feature priority/normal This is the priority for most work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants