-
Notifications
You must be signed in to change notification settings - Fork 302
feat(ui): ssh private key support #5404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Mayursinh Sarvaiya <[email protected]>
Signed-off-by: Mayursinh Sarvaiya <[email protected]>
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5404 +/- ##
==========================================
- Coverage 56.10% 56.09% -0.01%
==========================================
Files 411 411
Lines 30063 30077 +14
==========================================
+ Hits 16868 16873 +5
- Misses 12221 12227 +6
- Partials 974 977 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| string username = 6; | ||
| // password is the password or token for authentication. | ||
| string password = 7; | ||
| string ssh_private_key = 9; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need to eventually support GitHub App Authentication. Which has the fields:
githubAppClientIDgithubAppPrivateKeygithubAppInstallationID
Is continually expanding CreateCredentialsRequest API the sustainable approach to this?
Should UI switch to the Apply endpoint and just create Secret resources with baked-in understanding of the various fields (username/password/privatekey/githubXXXX/etc...)? Then the ConnectRPC API layer never needs to updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh. I thought its only sshPrivateKey. You are right, we should start using generic secrets.
Are you suggesting is to remove CreateCredentials approach? even for normal credentials?
#5149