-
Notifications
You must be signed in to change notification settings - Fork 302
feat: shared resources namespace #5428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: fuskovic <[email protected]>
Signed-off-by: fuskovic <[email protected]>
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: fuskovic <[email protected]>
Signed-off-by: fuskovic <[email protected]>
Signed-off-by: fuskovic <[email protected]>
Signed-off-by: fuskovic <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5428 +/- ##
==========================================
- Coverage 56.12% 55.09% -1.03%
==========================================
Files 411 426 +15
Lines 30058 31536 +1478
==========================================
+ Hits 16871 17376 +505
- Misses 12213 13159 +946
- Partials 974 1001 +27 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: fuskovic <[email protected]>
Co-authored-by: Hidde Beydals <[email protected]>
Signed-off-by: fuskovic <[email protected]>
|
Even though what @fuskovic is doing in this PR is 100% in-line with what I'd proposed in #4778, I am having some second thoughts. The "global credentials namespaces" supported credential lookup by type + URL rather than by direct reference. The corollary to that was that these credentials essentially became ambient. Developers working within individual projects did not actually have any way of seeing the credentials. That was deliberate, however, taking #4777 into account, it seems we are on the verge of making these credentials directly accessible by developers and I think that weakens Kargo's security posture quite a bit. None of this is to say that we don't need to do something about #4778. There is very clearly confusion between "global credentials namespaces" and "cluster secrets namespace." I do not find it confusing, personally, but I do see a litany of other reasons to rethink how it all works now. I think it would be foolish for us to charge ahead with these changes without stopping for a group sanity check, so imho, we should put a pin in this and thunderdome it after Thanksgiving. |
Signed-off-by: fuskovic <[email protected]>
Signed-off-by: fuskovic <[email protected]>
Deprecates
GLOBAL_CREDENTIALS_NAMESPACESin favor of newSHARED_RESOURCES_NAMESPACE.Related to: #4778