Skip to content

Conversation

@fuskovic
Copy link
Member

@fuskovic fuskovic commented Nov 28, 2025

Deprecates CLUSTER_SECRETS_NAMESPACE in favor of new CLUSTER_RESOURCES_NAMESPACE.

Related to: #4778

@fuskovic fuskovic self-assigned this Nov 28, 2025
@fuskovic fuskovic requested review from a team as code owners November 28, 2025 11:27
@fuskovic fuskovic added kind/refactor Non-functional changes to implementation details area/chart Affects the Helm chart labels Nov 28, 2025
@netlify
Copy link

netlify bot commented Nov 28, 2025

Deploy Preview for docs-kargo-io ready!

Name Link
🔨 Latest commit 500f44c
🔍 Latest deploy log https://app.netlify.com/projects/docs-kargo-io/deploys/69298a4661742f0008472f1e
😎 Deploy Preview https://deploy-preview-5433.docs.kargo.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Nov 28, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.07%. Comparing base (f1e86a3) to head (500f44c).

Files with missing lines Patch % Lines
pkg/server/delete_cluster_secret_v1alpha1.go 0.00% 4 Missing ⚠️
pkg/server/list_cluster_secrets_v1alpha1.go 25.00% 2 Missing and 1 partial ⚠️
pkg/server/update_cluster_secret_v1alpha1.go 25.00% 2 Missing and 1 partial ⚠️
pkg/webhook/external/config.go 0.00% 2 Missing ⚠️
pkg/server/config/config.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5433   +/-   ##
=======================================
  Coverage   55.07%   55.07%           
=======================================
  Files         426      426           
  Lines       31487    31487           
=======================================
  Hits        17342    17342           
  Misses      13145    13145           
  Partials     1000     1000           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: fuskovic <[email protected]>
@fuskovic fuskovic marked this pull request as draft December 1, 2025 10:36
@Plork
Copy link
Contributor

Plork commented Dec 8, 2025

When doing this is it maybe possible to add annotations to the namespace? In case of permitted regex for for example external-secrets.

          external-secrets.io/allowed-secret-store: ""
          external-secrets.io/permitted-key-regex: ""

When creating the namespace it would help if we can provide these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/chart Affects the Helm chart kind/refactor Non-functional changes to implementation details

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants