fix(promotion): propagate errors for backoff #5491
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Return errors from the orchestrator through the engine to the controller to trigger a progressive backoff. The engine now passes through orchestrator results unchanged. The controller then preserves the `Running` status when an error is returned and returns it to trigger the backoff. Signed-off-by: Hidde Beydals <[email protected]>
hiddeco
added
kind/bug
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5491 +/- ##
=======================================
Coverage 55.35% 55.35%
=======================================
Files 430 430
Lines 31851 31846 -5
=======================================
- Hits 17631 17629 -2
+ Misses 13214 13212 -2
+ Partials 1006 1005 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return errors from the orchestrator through the engine to the controller to trigger a progressive backoff. The engine now passes through the orchestrator results unchanged. The controller then preserves the
Runningstatus when an error is returned and returns it to trigger the backoff.