feat: make controller requeue delays configurable#5509
Open
omerzifman wants to merge 2 commits intoakuity:mainfrom
Open
feat: make controller requeue delays configurable#5509omerzifman wants to merge 2 commits intoakuity:mainfrom
omerzifman wants to merge 2 commits intoakuity:mainfrom
Conversation
Signed-off-by: Omer Zifman <omerzifman@gmail.com>
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 12 out of 12 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4969
This PR makes the reconcile requeue delay configurable for the following controllers:
regular_stages.go)projects.go)project_configs.go)cluster_configs.go)Previously, these controllers used a hard-coded 5-minute requeue delay. Operators can now tune this interval via Helm values or environment variables, with the default remaining at 5 minutes for backward compatibility.
Changes
Go Code
RequeueIntervalfield to each controller'sReconcilerConfigstruct withenvconfigtags and a default of5mReconcilemethods to use the configurable interval instead of hard-coded5 * time.MinuteHelm Chart
controller.reconcilers.stages.requeueIntervalmanagementController.reconcilers.projects.requeueIntervalmanagementController.reconcilers.projectConfigs.requeueIntervalmanagementController.reconcilers.clusterConfigs.requeueIntervalDocumentation
docs/docs/40-operator-guide/20-advanced-installation/30-common-configurations.md)Usage