feat: Add squash merge support to git-merge-pr promotion step#5581
feat: Add squash merge support to git-merge-pr promotion step#5581bobdoah wants to merge 5 commits intoakuity:mainfrom
Conversation
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
hiddeco
left a comment
There was a problem hiding this comment.
Thanks for implementing this, and I think it is a fair feature request. I made a couple of suggestions here and there.
My primary concern, other than what's commented, is that we silently ignore merge methods not supported by the selected provider. I think we should either:
- Return an error when a user specifies a merge method that the provider doesn't support
- Log a warning so users understand their preference wasn't honored
I'd lean toward option 1, as it's typically better to fail explicitly than to silently do something different from what the user requested.
docs/docs/50-user-guide/60-reference-docs/30-promotion-steps/git-merge-pr.md
Show resolved
Hide resolved
docs/docs/50-user-guide/60-reference-docs/30-promotion-steps/git-merge-pr.md
Outdated
Show resolved
Hide resolved
docs/docs/50-user-guide/60-reference-docs/30-promotion-steps/git-merge-pr.md
Outdated
Show resolved
Hide resolved
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #5581 +/- ##
==========================================
+ Coverage 56.29% 56.34% +0.04%
==========================================
Files 426 426
Lines 32262 32308 +46
==========================================
+ Hits 18163 18204 +41
- Misses 13045 13050 +5
Partials 1054 1054 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hey, you're welcome and thanks for the comments. I had considered either of those two options. I didn't see how I might go about option 2. I guess I thought it would fail how it currently does. I can see how option 1 is preferable, and help users. Hopefully my latest changes address your comments. Happy to change/reword anything if you've got any other preferences! |
f6f4c62 to
c65237b
Compare
|
I've made some further changes as the code coverage drop was flagged as a failure. |
Adds a new 'mergeMethod' configuration option to the git-merge-pr promotion step that allows users to specify the merge strategy when merging pull requests. Signed-off-by: Robert Williams <bobdoah@users.noreply.github.com>
Signed-off-by: Robert Williams <1266467+bobdoah@users.noreply.github.com>
Signed-off-by: Robert Williams <1266467+bobdoah@users.noreply.github.com>
Signed-off-by: Robert Williams <1266467+bobdoah@users.noreply.github.com>
Signed-off-by: Robert Williams <1266467+bobdoah@users.noreply.github.com>
|
I think this is best combined with #5454 as I suspect the resolved SHA for GitLab will otherwise be wrong. |
Adds a new 'mergeMethod' configuration option to the git-merge-pr promotion step that allows users to specify the merge strategy when merging pull requests.
This fulfils the feature request I opened in #5580.