Skip to content

fix: url normalization to account for unusual white space characters#5637

Open
fuskovic wants to merge 23 commits intomainfrom
fuskovic/fix-url-normalization
Open

fix: url normalization to account for unusual white space characters#5637
fuskovic wants to merge 23 commits intomainfrom
fuskovic/fix-url-normalization

Conversation

@fuskovic
Copy link
Member

@fuskovic fuskovic commented Jan 27, 2026

Closes #5616

Signed-off-by: fuskovic <fhuskovic92@gmail.com>
Signed-off-by: fuskovic <fhuskovic92@gmail.com>
Signed-off-by: fuskovic <fhuskovic92@gmail.com>
…elm tests to support new whitespace sanitization

Signed-off-by: fuskovic <fhuskovic92@gmail.com>
Signed-off-by: fuskovic <fhuskovic92@gmail.com>
Signed-off-by: fuskovic <fhuskovic92@gmail.com>
@fuskovic fuskovic self-assigned this Jan 27, 2026
@fuskovic fuskovic requested a review from a team as a code owner January 27, 2026 12:46
@fuskovic fuskovic added kind/bug Something isn't working as intended; If unsure that something IS a bug, start a discussion instead priority/high Needs to be addressed sooner rather than later area/test Affects tests (other than unit tests) labels Jan 27, 2026
@netlify
Copy link

netlify bot commented Jan 27, 2026

Deploy Preview for docs-kargo-io ready!

Name Link
🔨 Latest commit 8ef5187
🔍 Latest deploy log https://app.netlify.com/projects/docs-kargo-io/deploys/698420dc1678b80007a9c9f1
😎 Deploy Preview https://deploy-preview-5637.docs.kargo.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Jan 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.16%. Comparing base (b7b9006) to head (8ef5187).
⚠️ Report is 33 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5637      +/-   ##
==========================================
- Coverage   56.29%   56.16%   -0.14%     
==========================================
  Files         426      448      +22     
  Lines       32262    37669    +5407     
==========================================
+ Hits        18163    21156    +2993     
- Misses      13045    15256    +2211     
- Partials     1054     1257     +203     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@krancour krancour added this to the v1.9.1 milestone Jan 27, 2026
Signed-off-by: fuskovic <fhuskovic92@gmail.com>
Signed-off-by: fuskovic <fhuskovic92@gmail.com>
Signed-off-by: fuskovic <fhuskovic92@gmail.com>
Signed-off-by: fuskovic <fhuskovic92@gmail.com>
Signed-off-by: fuskovic <fhuskovic92@gmail.com>
@krancour krancour modified the milestones: v1.9.1, v1.9.2 Jan 31, 2026
Signed-off-by: fuskovic <fhuskovic92@gmail.com>
Signed-off-by: fuskovic <fhuskovic92@gmail.com>
Signed-off-by: fuskovic <fhuskovic92@gmail.com>
Signed-off-by: fuskovic <fhuskovic92@gmail.com>
Signed-off-by: fuskovic <fhuskovic92@gmail.com>
Signed-off-by: fuskovic <fhuskovic92@gmail.com>
@fuskovic
Copy link
Member Author

fuskovic commented Feb 3, 2026

@krancour I have this in a place now where we are retaining the existing behavior and handling the new edge cases. If something doesn't look necessary I recommend trying to remove it and running the tests.

@fuskovic fuskovic requested a review from krancour February 3, 2026 05:29
Signed-off-by: fuskovic <fhuskovic92@gmail.com>
@hiddeco hiddeco modified the milestones: v1.9.2, v1.9.3 Feb 3, 2026
Signed-off-by: fuskovic <fhuskovic92@gmail.com>
Signed-off-by: fuskovic <fhuskovic92@gmail.com>
Signed-off-by: fuskovic <fhuskovic92@gmail.com>
Signed-off-by: fuskovic <fhuskovic92@gmail.com>
Signed-off-by: fuskovic <fhuskovic92@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/test Affects tests (other than unit tests) kind/bug Something isn't working as intended; If unsure that something IS a bug, start a discussion instead priority/high Needs to be addressed sooner rather than later

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug in url normalization

3 participants