Skip to content

feat(chart): allow for template on host input#5718

Open
jdcmarques wants to merge 2 commits intoakuity:mainfrom
jdcmarques:allow-host-templates
Open

feat(chart): allow for template on host input#5718
jdcmarques wants to merge 2 commits intoakuity:mainfrom
jdcmarques:allow-host-templates

Conversation

@jdcmarques
Copy link

Description

  • Allow for hostnames to be helm temptable
    • api.host
    • api.argocd.urls{*}
    • externalWebhooksServer.host

Previously the fields must have been set with

api:
  host: kargo.example.com
externalWebhooksServer:
  host: webhooks.kargo.example.com

We can now do something like:

global:
  baseDomain: 'example.com'

api:
  host: "kargo.{{ .Values.global.baseDomain }}"
externalWebhooksServer:
  host: "webhooks.kargo.{{ .Values.global.baseDomain }}"  

Validation

Rendered before and after proposed changes and had no diff in the outcome templates

  • api.oidc.enabled - true and false
  • api.oidc.dex.enabled - true and false
  • api.tls.enabled.selfSignedCert - true and false
  • externalWebhooksServer.tls.enabled - true and false
  • externalWebhooksServer.tls.selfSignedCert - true and false

Addresses #5630

@jdcmarques jdcmarques requested a review from a team as a code owner February 10, 2026 09:36
@netlify
Copy link

netlify bot commented Feb 10, 2026

Deploy Preview for docs-kargo-io ready!

Name Link
🔨 Latest commit 3d389b1
🔍 Latest deploy log https://app.netlify.com/projects/docs-kargo-io/deploys/698b056afb70fc0008d1be89
😎 Deploy Preview https://deploy-preview-5718.docs.kargo.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Signed-off-by: Jose Marques <jose.marques@fanduel.com>
Signed-off-by: Jose Marques <jose.marques@fanduel.com>
@krancour krancour added needs discussion A maintainer explicitly requests no action be taken without further discussion area/chart Affects the Helm chart needs/priority Priority has not yet been determined; a good signal that maintainers aren't fully committed kind/enhancement An entirely new feature kind/proposal Indicates maintainers have not yet committed to a feature request labels Feb 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/chart Affects the Helm chart kind/enhancement An entirely new feature kind/proposal Indicates maintainers have not yet committed to a feature request needs discussion A maintainer explicitly requests no action be taken without further discussion needs/priority Priority has not yet been determined; a good signal that maintainers aren't fully committed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants