feat: git tag step + tag support for git push#5785
Conversation
Signed-off-by: fuskovic <fhuskovic92@gmail.com>
Signed-off-by: fuskovic <fhuskovic92@gmail.com>
Signed-off-by: fuskovic <fhuskovic92@gmail.com>
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #5785 +/- ##
==========================================
- Coverage 56.25% 56.24% -0.01%
==========================================
Files 451 452 +1
Lines 37840 37959 +119
==========================================
+ Hits 21286 21350 +64
- Misses 15293 15340 +47
- Partials 1261 1269 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: fuskovic <fhuskovic92@gmail.com>
… while keeping things DRY Signed-off-by: fuskovic <fhuskovic92@gmail.com>
Signed-off-by: fuskovic <fhuskovic92@gmail.com>
Signed-off-by: fuskovic <fhuskovic92@gmail.com>
Signed-off-by: fuskovic <fhuskovic92@gmail.com>
Signed-off-by: fuskovic <fhuskovic92@gmail.com>
Signed-off-by: fuskovic <fhuskovic92@gmail.com>
Signed-off-by: fuskovic <fhuskovic92@gmail.com>
Signed-off-by: fuskovic <fhuskovic92@gmail.com>
Signed-off-by: fuskovic <fhuskovic92@gmail.com>
Signed-off-by: fuskovic <fhuskovic92@gmail.com>
docs/docs/50-user-guide/60-reference-docs/30-promotion-steps/git-push.md
Outdated
Show resolved
Hide resolved
docs/docs/50-user-guide/60-reference-docs/30-promotion-steps/git-push.md
Outdated
Show resolved
Hide resolved
docs/docs/50-user-guide/60-reference-docs/30-promotion-steps/git-push.md
Outdated
Show resolved
Hide resolved
docs/docs/50-user-guide/60-reference-docs/30-promotion-steps/git-push.md
Outdated
Show resolved
Hide resolved
docs/docs/50-user-guide/60-reference-docs/30-promotion-steps/git-tag.md
Outdated
Show resolved
Hide resolved
docs/docs/50-user-guide/60-reference-docs/30-promotion-steps/git-tag.md
Outdated
Show resolved
Hide resolved
docs/docs/50-user-guide/60-reference-docs/30-promotion-steps/git-tag.md
Outdated
Show resolved
Hide resolved
| if reg.Predicate != nil && reg.NewProvider != nil { | ||
| if reg.Predicate(repoURL) { | ||
| return reg.NewProvider(repoURL, opts) | ||
| } |
There was a problem hiding this comment.
Total aside and note to self... I realize this code wasn't ever refactored to use the PredicateBasedRegistry. Out of scope for this PR, but I should fix that.
docs/docs/50-user-guide/60-reference-docs/30-promotion-steps/git-push.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: fuskovic <fhuskovic92@gmail.com>
Signed-off-by: fuskovic <fhuskovic92@gmail.com>
Signed-off-by: fuskovic <fhuskovic92@gmail.com>
Signed-off-by: fuskovic <fhuskovic92@gmail.com>
Signed-off-by: fuskovic <fhuskovic92@gmail.com>
Signed-off-by: fuskovic <fhuskovic92@gmail.com>
Signed-off-by: fuskovic <fhuskovic92@gmail.com>
Signed-off-by: fuskovic <fhuskovic92@gmail.com>
Signed-off-by: fuskovic <fhuskovic92@gmail.com>
Signed-off-by: fuskovic <fhuskovic92@gmail.com>
|
@krancour I've pushed the suggested changes and updated the demo in the PR description to show the commit information. Some notes:
Alternatively, we can always set all output keys unconditionally so they can always be referenced dynamically in other steps (regardless if they're empty). Thoughts? |
Closes: #5737
Demo
tag+push-demo.mov