feat(chart): per-controller argocd ClusterRole; tpl env + envFrom values#6427
Open
krancour wants to merge 1 commit into
Open
feat(chart): per-controller argocd ClusterRole; tpl env + envFrom values#6427krancour wants to merge 1 commit into
krancour wants to merge 1 commit into
Conversation
`kargo-controller-argocd` ClusterRole is now per-controller -- name suffixed via the controller fullname helper, gated on `argocd.dataPlane.kargoController.install` rather than the data-plane-wide `argocd.dataPlane.install`. Lets the argocd CR be emitted as part of a per-agent manifest set in topologies that manage the argo CD data plane per-agent. With no `controller.id` set, the rendered name remains `kargo-controller-argocd`, preserving the single-controller shape. The per-controller CRB's roleRef updates accordingly. Also: `tpl` applied to rendered `env` and `envFrom` lists across api, controller, management-controller, kubernetes-webhooks-server, external-webhooks-server, dex-server, and garbage-collector. Operators can now reference helper output (e.g., `kargo.controller.fullname`) in injected env/envFrom entries; previously those rendered as literal text. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
krancour
added
kind/enhancement
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6427 +/- ##
=======================================
Coverage 58.34% 58.34%
=======================================
Files 500 500
Lines 41993 41993
=======================================
Hits 24500 24500
Misses 16024 16024
Partials 1469 1469 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intended for use downstream:
The
kargo-controller-argocdClusterRole is now per-controller — name suffixed via the controller fullname helper, gated onargocd.dataPlane.kargoController.installrather than the data-plane-wideargocd.dataPlane.install. With nocontroller.idset the rendered name remainskargo-controller-argocd, preserving today's shape; the per-controller CRB'sroleRefupdates accordingly.tplapplied to the renderedenvandenvFromlists across api, controller, management-controller, kubernetes-webhooks-server, external-webhooks-server, dex-server, and garbage-collector. Operators can now reference helper output (e.g.,kargo.controller.fullname) in injectedenv/envFromentries; previously those rendered as literal text.