Skip to content

Fix for issues #1782 & #1767#1790

Open
psegalen wants to merge 5 commits into
akveo:masterfrom
psegalen:master
Open

Fix for issues #1782 & #1767#1790
psegalen wants to merge 5 commits into
akveo:masterfrom
psegalen:master

Conversation

@psegalen

@psegalen psegalen commented Nov 7, 2023

Copy link
Copy Markdown

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Issue #1767 is about modal flickering, it is caused by assigning decimal dimensions on modals, the fix just adds a Math.round() to width and height for Frames.

Issue #1782 is about a crash happening only on iOS when UI Kitten tries to measure a node that RN did not find, Android seems to support it but it makes an iOS app crash.

@psegalen

psegalen commented Nov 7, 2023

Copy link
Copy Markdown
Author

I think it fixes #1751 so it may be taken for a duplicate of #1752 but it fixes 2 issues in one PR

Comment thread src/components/devsupport/components/measure/measure.component.tsx Outdated
….tsx

Co-authored-by: raqso <raqsasg@gmail.com>
@robpearmain

Copy link
Copy Markdown

Hi. Is there a release, or planned release soon to fix the measureInWindow issue please

react/react-native#41730

@rklomp rklomp mentioned this pull request Feb 6, 2024
@rklomp

rklomp commented Feb 6, 2024

Copy link
Copy Markdown

@psegalen See my comment at #1767 and #1802

I had to use Math.floor() to fix my issue instead of Math.round().

@alexander-schranz

Copy link
Copy Markdown

I just copied a patch to: https://github.com/ui-cat/react-native-ui-cat/pull/5/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants