Do not isolate tests - #27
Closed
radarhere wants to merge 5 commits into
Closed
Conversation
Pass the options at each call site rather than putting them in addopts, so pytests may also run without test-xdist. REVERSE dropped because xdist runs tests in arbitrary order anyhow. That matrix entry still does PYTHONOPTIMIZE=1. Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
* ru_maxrss never falls, so leak tests were measuring occasional transient spikes, not true leaks. Instead, for leak tests we now read the current RSS, which falls (to a degree, depending on system allocator strategy) when memory is released, and also doesn't depend on the process's past. * The tests' limits were adjusted based on empirical measurements.
This reverts commit 15e3d82.
Owner
|
It was a "maybe" :) Since the failures are flakes, a PR will likely not show them. |
Author
|
How many times does it need to run successfully before it stops being maybe? |
Owner
|
I can remove the isolation and we can merge the xdist PR without it, and then add isolation back if needed. Is that OK? |
Author
|
Sounds like a plan to me. |
Owner
|
Removed isolation in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggestion for python-pillow#9945
If you don't think we need to isolate tests, then let's not.