Skip to content

Fix Ctrl key toggling "Keep adding" button + Add Ctrl+K shortcut #2042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 14, 2025
+8 −4
Merged

Fix Ctrl key toggling "Keep adding" button + Add Ctrl+K shortcut #2042

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
659957b
fix ctrl key
alainm23 Nov 14, 2025
6230364
Merge branch 'master' into fix/2034
alainm23 Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions core/QuickAddCore.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,7 +575,6 @@ public class Layouts.QuickAddCore : Adw.Bin {
signal_map[event_controller_key.key_pressed.connect ((keyval, keycode, state) => {
if (keyval == Gdk.Key.Control_L || keyval == Gdk.Key.Control_R) {
ctrl_pressed = true;
create_more_button.active = ctrl_pressed;
}

return false;
Expand All @@ -584,7 +583,6 @@ public class Layouts.QuickAddCore : Adw.Bin {
signal_map[event_controller_key.key_released.connect ((keyval, keycode, state) => {
if (keyval == Gdk.Key.Control_L || keyval == Gdk.Key.Control_R) {
ctrl_pressed = false;
create_more_button.active = ctrl_pressed;
}
})] = event_controller_key;

Expand Down Expand Up @@ -632,9 +630,15 @@ public class Layouts.QuickAddCore : Adw.Bin {
return true;
}));

var toggle_keep_adding_shortcut = new Gtk.Shortcut (Gtk.ShortcutTrigger.parse_string ("<Control>k"), new Gtk.CallbackAction (() => {
create_more_button.active = !create_more_button.active;
return true;
}));

shortcut_controller = new Gtk.ShortcutController ();
shortcut_controller.add_shortcut (open_label_shortcut);
shortcut_controller.add_shortcut (open_reminder_shortcut);
shortcut_controller.add_shortcut (toggle_keep_adding_shortcut);
add_controller (shortcut_controller);

destroy_controller = new Gtk.EventControllerKey ();
Expand Down Expand Up @@ -1272,7 +1276,7 @@ public class Layouts.QuickAddCore : Adw.Bin {
margin_top = 3,
margin_bottom = 3
});
popover_box.append (build_shortcut_widget ("⮑", "#1e63ec", _("Keep adding"), _("Stay open after creating task")));
popover_box.append (build_shortcut_widget ("Ctrl+K", "#1e63ec", _("Keep adding"), _("Toggle stay open after creating task")));
popover_box.append (new Widgets.ContextMenu.MenuSeparator () {
margin_top = 3,
margin_bottom = 3
Expand Down Expand Up @@ -1303,7 +1307,7 @@ public class Layouts.QuickAddCore : Adw.Bin {

private Gtk.Widget build_shortcut_widget (string shortcut_key, string color, string title, string subtitle) {
var shortcut_label = new Gtk.Label (shortcut_key) {
width_chars = 5,
width_chars = 6,
valign = CENTER
};
shortcut_label.add_css_class ("caption");
Expand Down