combined commit for all the work done - rebase on latest version#190
Open
renierr wants to merge 25 commits intoalam00000:mainfrom
Open
combined commit for all the work done - rebase on latest version#190renierr wants to merge 25 commits intoalam00000:mainfrom
renierr wants to merge 25 commits intoalam00000:mainfrom
Conversation
- add flattening as image tool - add html to pdf tool (with Wysiwyg quill editor) - PWA app for offline usage - add loading screen (helpful for simple mode - reduce flicker when hiding branding) - vite env file loading in config - some tweaks for example: -- simple mode hiding with styles -- git ignores remove online dependency to https://snippet.embedpdf.com/embedpdf.js (because it is not true 100% offline then) - fallback to browser editor as embedding. TODO: removed a flatten option for sign, because it was rewritten may be add it in a later commit
Owner
|
@renierr Great thank you. I would review it later. However, the HTML to PDF, is just an advanced Text to PDF I believe as you can't really paste HTML in quill. So we could just replace the text to pdf's type functionality with this |
Author
|
you can past html into the wysiwyg editor, or write rich text directly into it with toolbar and some options. |
Owner
|
Does it support css |
Author
|
This is how it looks |
Author
|
the conversion is in code to pdf. currently what you can select in toolbar. no further config, but could be enhanced like, selecting font etc. I am open to change the UI to look different. Or other changes to the PR |
(cherry picked from commit c81ebec)
page size, page orientation, default font and size
better sizing to fit to page
page size, page orientation, default font and size (cherry picked from commit abc0e21)
(cherry picked from commit 8419327)
better sizing to fit to page (cherry picked from commit ee205f6)
exclude pdfjs-* (viewer) stuff for iframe calls. the viewer cannot be used offline because of the blob url passed in viewer.html (changed for every blob)
exclude pdfjs-* (viewer) stuff for iframe calls. the viewer cannot be used offline because of the blob url passed in viewer.html (changed for every blob) (cherry picked from commit 370488a)
use the default and user-provided styles
use the default and user-provided styles (cherry picked from commit 7b7b7f1)
# Conflicts: # src/css/styles.css # vite.config.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
-- git ignores
remove online dependency to
https://snippet.embedpdf.com/embedpdf.js
(because it is not true 100% offline then) - fallback to browser editor as embedding.
TODO: removed a flatten option for sign, because it was rewritten may be add it in a later commit
see previous PR from me - this is a nice squashed condensed version.
Highlight is the HTML to PDF with an wysiwyg editor.
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Type of change
Please delete options that are not relevant.
🧪 How Has This Been Tested?
Please describe how you tested your changes so that maintainers can verify them. Include enough detail for someone else to reproduce your tests.
Checklist:
Expected Results:
Actual Results:
Checklist: