(Feature) Keep watermark settings after generating PDF#297
Open
AB527 wants to merge 1 commit intoalam00000:mainfrom
Open
(Feature) Keep watermark settings after generating PDF#297AB527 wants to merge 1 commit intoalam00000:mainfrom
AB527 wants to merge 1 commit intoalam00000:mainfrom
Conversation
- Added reset button to clear watermark settings. - Implemented loading of watermark configurations from local storage. - Updated text and image watermark handling in the reset function.
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the watermark generation workflow by persisting watermark settings after PDF generation instead of resetting them automatically.
Previously, generating a PDF would clear all watermark configurations, requiring users to re-enter the same settings for every iteration. This change ensures that watermark options (text and image) are retained until the user explicitly resets them, making iterative watermark adjustments significantly less tedious.
A Reset button has been added to allow users to manually clear watermark settings when required. Watermark configurations are now stored in local storage and restored automatically after PDF generation.
Fixes #291
Type of change
🧪 How Has This Been Tested?
The changes were tested manually by performing multiple PDF generations in sequence using the same watermark settings.
Checklist:
Expected Results:
Actual Results:
Checklist:
Note to maintainers:
This is my first pull request to this project. I have tried to follow the guidelines as closely as possible, but please let me know if there is anything I missed or if there are any areas for improvement in the code. I'm happy to make any necessary changes. Thank you for your review !