Implement missing i18n translations for PDF-to-Image modules#565
Open
Skillkiller wants to merge 13 commits intoalam00000:mainfrom
Open
Implement missing i18n translations for PDF-to-Image modules#565Skillkiller wants to merge 13 commits intoalam00000:mainfrom
Skillkiller wants to merge 13 commits intoalam00000:mainfrom
Conversation
This reverts commit 3093dcb.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I noticed that a few spots in the PDF-to-Image modules were still stuck in English, which stands out a bit when you're using the app in another language. To fix this, I’ve hooked up the missing translations for five modules using the existing i18n structure. I added some new keys to common and tools, keeping them organized under their respective namespaces to match how things are currently set up.
Since these modules are quite similar, some of the translations overlap. I did think about grouping everything under a shared pdfToImage key or even refactoring the modules into a single shared component to get rid of the code duplication, as there's definitely a lot of "copy-paste" feel there. I’m totally open to your thoughts on whether you'd like to see that kind of cleanup later!
I also took the chance to fix the same strings in a few other modules I stumbled upon while working on this.
One quick heads-up: My IDE/ESLint went ahead and reformatted
src/js/logic/digital-sign-pdf-page.tsandsrc/js/logic/sign-pdf-page.tswhen I committed, which is why the diff for those files looks a bit huge. If that’s annoying or you want to keep this PR strictly about the translations, just let me know—I’m happy to revert the formatting and keep it focused.Note on Localization
I’ve added the new locale keys for both German and English, as these are the languages I could cover. For the other languages currently supported by the app, I wasn't sure what the preferred workflow is: Should I add the new keys to those JSON files and leave the strings empty (or in English), or is it better to leave them out entirely for now?
Type of change
Please delete options that are not relevant.
🧪 How Has This Been Tested?
I tested these changes manually by switching the application language and walking through the flow of the affected PDF-to-Image modules. I verified that all previously hardcoded English labels are now correctly replaced by the translated strings and that the fallback to English still works as expected.
Checklist:
Expected Results:
The UI should now dynamically pull all strings from the i18n files instead of using hardcoded English text. When switching the application language, every label within the PDF-to-Image modules and the related shared components should update correctly to the selected language without breaking the layout or causing console errors.
Actual Results:
After implementing the new keys, I confirmed that the translations are being applied as expected. Switching between languages now shows the localized strings in all five modules.
Checklist: