fix: support both docker-compose and docker compose commands#26
Merged
fix: support both docker-compose and docker compose commands#26
Conversation
Detects whether docker-compose (legacy) or docker compose (modern Docker CLI) is available and uses the appropriate command automatically. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
florian-ernst-alan
approved these changes
May 28, 2025
florian-ernst-alan
left a comment
florian-ernst-alan
left a comment
There was a problem hiding this comment.
LGTM, however I think a much simpler approach is to simply switch everything to docker compose (as it's been available for years, coexisting with docker-compose).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤓 Why
Newer versions of Docker use
docker composeinstead of the legacydocker-composecommand. The currentmwaa-local-envscript only supports the legacy command, causing compatibility issues for users with newer Docker installations.💪 How
Added automatic detection of available docker compose command:
docker-compose(legacy standalone tool)docker compose(modern Docker CLI plugin)🧪 Tests
docker compose). Could you (dear reviewer) test it with your setup if it'sdocker-composecompatible ?🤖 Generated with Claude Code