Skip to content

Fix checkpoint callback state keys#351

Merged
sgreenbury merged 1 commit intomainfrom
fix-callbacks
Apr 24, 2026
Merged

Fix checkpoint callback state keys#351
sgreenbury merged 1 commit intomainfrom
fix-callbacks

Conversation

@sgreenbury
Copy link
Copy Markdown
Contributor

Summary

  • include progress-window fields in ProgressModelCheckpoint state keys
  • add regression coverage for duplicate callback keys
  • instantiate the default trainer config in tests to catch this failure

Testing

  • uv run pytest tests/scripts/test_training.py
  • uv run ruff check src/autocast/callbacks/checkpoint.py tests/scripts/test_training.py
  • git diff --check

Include progress-window settings in ProgressModelCheckpoint state keys
so multiple checkpoint callbacks can coexist in the default trainer
config.

Add regression coverage for duplicate state keys and default Trainer
instantiation so PR #350 callback regressions fail loudly.
@sgreenbury sgreenbury merged commit bed4611 into main Apr 24, 2026
3 checks passed
@sgreenbury sgreenbury deleted the fix-callbacks branch April 24, 2026 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant