Skip to content

Add compare for experimental #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Apr 25, 2025
Merged

Add compare for experimental #397

merged 21 commits into from
Apr 25, 2025

Conversation

sgreenbury
Copy link
Collaborator

@sgreenbury sgreenbury commented Apr 11, 2025

Closes #371.
Closes #427

Base automatically changed from 349-refactor-gp to main April 15, 2025 17:21
Copy link
Contributor

github-actions bot commented Apr 16, 2025

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  autoemulate/emulators
  gaussian_process.py
  autoemulate/experimental
  compare.py
  model_selection.py
  autoemulate/experimental/data
  utils.py 87
  autoemulate/experimental/emulators
  __init__.py
  base.py
  lightgbm.py
  autoemulate/experimental/emulators/gaussian_process
  exact.py
  autoemulate/experimental/emulators/neural_processes
  conditional_neural_process.py
  tests/experimental
  test_experimental_base.py 124
  test_experimental_compare.py
  test_experimental_conditional_neural_process.py
  test_experimental_model_selection.py 30
Project Total  

This report was generated by python-coverage-comment-action

@codecov-commenter
Copy link

codecov-commenter commented Apr 16, 2025

Codecov Report

Attention: Patch coverage is 97.43590% with 3 lines in your changes missing coverage. Please review.

Project coverage is 90.57%. Comparing base (20f42e1) to head (c105b1d).

Files with missing lines Patch % Lines
autoemulate/experimental/data/utils.py 91.66% 1 Missing ⚠️
tests/experimental/test_experimental_base.py 66.66% 1 Missing ⚠️
.../experimental/test_experimental_model_selection.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #397      +/-   ##
==========================================
+ Coverage   90.40%   90.57%   +0.17%     
==========================================
  Files          93       96       +3     
  Lines        5877     5983     +106     
==========================================
+ Hits         5313     5419     +106     
  Misses        564      564              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sgreenbury sgreenbury marked this pull request as ready for review April 23, 2025 13:59
Copy link
Member

@radka-j radka-j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! We might want to think about how we handle multi output data (since not all models can be applied to it) but we can do that in a separate PR (I opened an issue #427).

@radka-j radka-j merged commit 47be238 into main Apr 25, 2025
4 checks passed
@sgreenbury sgreenbury deleted the 371-compare branch May 6, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor: Multioutput handling Refactor: update compare method
3 participants