Skip to content

Fix FFMPEG issue#222

Merged
jemrobinson merged 7 commits intomainfrom
215-fix-ffmpeg-issue
Mar 2, 2026
Merged

Fix FFMPEG issue#222
jemrobinson merged 7 commits intomainfrom
215-fix-ffmpeg-issue

Conversation

@jemrobinson
Copy link
Copy Markdown
Member

  • use imageio-ffmpeg to install FFMPEG
  • set the appropriate matplotlib configuration to allow this to be used by default

Closes #215

P.S. I haven't tested this - if someone who's experiencing the problem can do so, that would be great.

@jemrobinson jemrobinson requested a review from a team February 19, 2026 16:11
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 20, 2026

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  icenet_mp
  plugins.py
  icenet_mp/visualisations
  __init__.py
Project Total  

This report was generated by python-coverage-comment-action

@jemrobinson jemrobinson force-pushed the 215-fix-ffmpeg-issue branch 2 times, most recently from 20ab330 to 98709b1 Compare February 27, 2026 14:22
@louisavz
Copy link
Copy Markdown
Contributor

I can give this a go and test it. What does good look like? The issue said "Revert ffmpeg dependency", we should still see the animation but now rely on ImageIO's library?

@jemrobinson
Copy link
Copy Markdown
Member Author

I think the best way to test is to do a minimal train run (e.g. with a simple model and 1 or 2 epochs) and then run evaluate on the checkpoint from that run. Evaluate is the step that runs the video generation.

  • It should not print the line Video plotting skipped: Video encoding failed: [Errno 2] No such file or directory: 'ffmpeg'.
  • It should produce the .mp4 video which gets uploaded to W&B.

@jemrobinson
Copy link
Copy Markdown
Member Author

@alan-turing-institute/sea-ice-prediction-developers: this is working for me on Isambard and it's been waiting for review for 2 weeks. If there are no objections I will merge it today.

@IFenton
Copy link
Copy Markdown
Contributor

IFenton commented Mar 2, 2026

@jemrobinson Do you want me to have a quick look at it first?

@jemrobinson
Copy link
Copy Markdown
Member Author

@IFenton if you have time but I'd rather have your focus on getting #216 merged. This PR fixes (or attempts to fix) something that's currently broken but doesn't seem to be problematic.

Copy link
Copy Markdown
Contributor

@IFenton IFenton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It produces the videos on Baskerville, which I think is where the problem was before

@jemrobinson jemrobinson merged commit 038e9c8 into main Mar 2, 2026
3 checks passed
@jemrobinson jemrobinson deleted the 215-fix-ffmpeg-issue branch March 2, 2026 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove ffmpeg dependency

3 participants