Fix wandb error on multi-GPU training#234
Merged
erinuclkwon merged 5 commits intomainfrom Feb 27, 2026
Merged
Conversation
erinuclkwon
changed the title
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||
jemrobinson
reviewed
Feb 27, 2026
| dataset.end_date, | ||
| ) | ||
| return DataLoader(dataset, shuffle=True, **self._common_dataloader_kwargs) | ||
| return DataLoader(dataset, shuffle=False, **self._common_dataloader_kwargs) |
Member
There was a problem hiding this comment.
Do we still need to disable shuffle?
Contributor
Author
There was a problem hiding this comment.
Actually, not anymore. Thanks for pointing it out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When training with multiple GPUs, subsequent ranks after rank 0, which has correct wandb object and directory, fail with
FileNotFoundErrorwhen attempting to savemodel_config.yaml to afiles/subdirectory that is never created.model_config_path.parent.mkdir(parents=True, exist_ok=True)was added to create the directory first. Addingis_global_zerorestricts config saving to rank 0 only, eliminating the error on subsequent ranks and automatically works on single GPU.