Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||
…sults in the IPython notebook
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an Argo float data source to the icenet_mp data processing pipeline, along with the necessary Python dependencies and a sample dataset configuration.
Changes:
- Introduces a new
ArgoSource(icenet_mp/data_processors/sources/argo.py) that fetches Argo data viaargopyand projects it onto a lat/lon grid. - Registers the new source alongside the existing FTP source.
- Adds
argopyandhaversinedependencies plus a sample dataset YAML, and updatesuv.lockaccordingly.
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
uv.lock |
Locks new dependencies (argopy, erddapy, haversine) and adjusts some resolved versions/markers. |
pyproject.toml |
Adds runtime deps (argopy, haversine) and mypy ignore entries for their modules. |
icenet_mp/data_processors/sources/argo.py |
New Argo source implementation with retry logic and gridding/weighting. |
icenet_mp/data_processors/sources/__init__.py |
Registers argo in register_sources() and exports ArgoSource. |
icenet_mp/config/data/datasets/samp_floatnorth_argo_pt_2017_2019_24h_v1.yaml |
Adds a sample dataset config for the new Argo source. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jemrobinson
reviewed
Mar 19, 2026
jemrobinson
reviewed
Mar 19, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
jemrobinson
approved these changes
Mar 25, 2026
Member
There was a problem hiding this comment.
Discussed with @IFenton. Happy for her to merge when ready.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #239