Skip to content

Fixing issue with SSMIS models#332

Merged
IFenton merged 1 commit into
mainfrom
331-ssmis-fix
Jun 26, 2026
Merged

Fixing issue with SSMIS models#332
IFenton merged 1 commit into
mainfrom
331-ssmis-fix

Conversation

@IFenton

@IFenton IFenton commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Closes #331

@IFenton IFenton requested review from Copilot and jemrobinson and removed request for Copilot June 26, 2026 10:31
@IFenton IFenton changed the title 🐛 Fixing issue with SSMIS models Fixing issue with SSMIS models Jun 26, 2026
@github-actions

Copy link
Copy Markdown

Coverage report

This PR does not seem to contain any modification to coverable code.

@jemrobinson jemrobinson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Is this the only issue with them though? Have you tested?

@IFenton

IFenton commented Jun 26, 2026

Copy link
Copy Markdown
Contributor Author

LGTM. Is this the only issue with them though? Have you tested?

I haven't tested all of them, but it now runs for the quick_test model, and I'm just checking the naive_unet_naive model

The one I was least sure of was the reproject_unet_naive model. Is this the correct fix for that one?

@jemrobinson

Copy link
Copy Markdown
Member

The one I was least sure of was the reproject_unet_naive model. Is this the correct fix for that one?

Yes, I think so, but we're unlikely to use that in any case (it's very slow and we're reprojecting at creation-time now).

@IFenton

IFenton commented Jun 26, 2026

Copy link
Copy Markdown
Contributor Author

For reference, here is a run of the quick_test model for the SSMIS data: https://wandb.ai/turing-seaice/evaluate/runs/7782f286?nw=nwuserifenton

@IFenton

IFenton commented Jun 26, 2026

Copy link
Copy Markdown
Contributor Author

Also runs fine for a CNN_UNet_CNN model: https://wandb.ai/turing-seaice/evaluate/runs/u2ea98af, so going to merge this now

@IFenton IFenton merged commit 07a2382 into main Jun 26, 2026
9 checks passed
@IFenton IFenton deleted the 331-ssmis-fix branch June 26, 2026 11:36
jemrobinson pushed a commit that referenced this pull request Jun 26, 2026
🐛 Fixing issue with SSMIS models
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix error with SSMIS data

2 participants