Add CI#38
Merged
jemrobinson merged 28 commits intomainfrom Aug 1, 2025
Merged
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
…ilding Zebra models
…w requirement imposed by icenet==0.2.7
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds basic continuous integration and development tooling to the project, including code style checks, testing infrastructure, and CI workflows.
Key changes include:
- Added development dependencies for testing and type checking (mypy, pytest, pre-commit)
- Set up automated CI workflows for code style checks, testing, and coverage reporting
- Updated Python version constraints to exclude 3.13 due to TensorFlow compatibility
- Applied consistent code formatting across all notebook files
Reviewed Changes
Copilot reviewed 28 out of 34 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Added build system configuration, dev dependencies, and tool configurations |
| tests/test_cli.py | New CLI test suite with custom runner for testing zebra commands |
| .github/workflows/ | CI workflows for code style, testing, and coverage reporting |
| .pre-commit-config.yaml | Pre-commit hooks configuration for automated code quality checks |
| ice_station_zebra/ | Type hint improvements and code style fixes across Python modules |
| notebook/ | Code formatting and style improvements in Jupyter notebooks |
| README.md, CONTRIBUTING.md | Updated documentation with development setup instructions |
Comments suppressed due to low confidence (3)
pyproject.toml:2
- The package 'uv_build' does not appear to be a valid Python package. This should likely be 'uv' or another valid build backend package name.
requires = ["uv_build>=0.8.3,<0.9.0"]
pyproject.toml:3
- The build backend 'uv_build' does not appear to be valid. Consider using a standard build backend like 'hatchling.build' or 'setuptools.build_meta'.
build-backend = "uv_build"
tests/test_cli.py:93
- [nitpick] The method name 'test_train_help' is inconsistent with other test methods in the class which use 'test_help'. Consider renaming to 'test_help' for consistency.
def test_train_help(self):
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
IFenton
reviewed
Jul 31, 2025
Contributor
IFenton
left a comment
There was a problem hiding this comment.
Generally it looks fine, but I hit a couple of problems when trying to test the pre-commit / pytest functionality (see the relevant notes). So I haven't yet managed to get them running.
jemrobinson
commented
Jul 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add some basic continuous-integration steps.
ruffpytestmypyIf you want to ensure your code passes locally before opening a PR you can run the tests locally following the instructions in CONTRIBUTING.md.