Add ddpm model#56
Merged
jemrobinson merged 49 commits intomainfrom Aug 28, 2025
Merged
Conversation
Co-authored-by: James Robinson <james.em.robinson@gmail.com> Co-authored-by: Isabel Fenton <ifenton@turing.ac.uk>
Co-authored-by: James Robinson <james.em.robinson@gmail.com> Co-authored-by: Isabel Fenton <ifenton@turing.ac.uk>
…same device as their inputs
jemrobinson
reviewed
Aug 15, 2025
jemrobinson
reviewed
Aug 15, 2025
jemrobinson
reviewed
Aug 15, 2025
33bc687 to
8fbdb6e
Compare
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Member
|
I can review this today/tomorrow. |
jemrobinson
requested changes
Aug 27, 2025
Member
jemrobinson
left a comment
There was a problem hiding this comment.
We should use B, C, H, W format throughout the diffusion process. Happy to help with implementing this if it's not clear how to do it.
We also don't need EMA to be implemented inside the model, as we're running EMA in a lightning callback.
Member
|
Also, can you add some tests for the model? If you merge |
Contributor
Author
|
Contributor
Author
|
Thank you so much, @jemrobinson, for the useful feedback. I will adjust them soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #55