Make activation function configurable as argument#60
Merged
marianovitasari20 merged 12 commits intomainfrom Aug 19, 2025
Merged
Make activation function configurable as argument#60marianovitasari20 merged 12 commits intomainfrom
marianovitasari20 merged 12 commits intomainfrom
Conversation
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||
jemrobinson
requested changes
Aug 18, 2025
2 tasks
…guments when we instantiate it. This is necessary to reproduce previous behaviour.
5448cac to
7f0def9
Compare
jemrobinson
approved these changes
Aug 19, 2025
Member
jemrobinson
left a comment
There was a problem hiding this comment.
LGTM
@marianovitasari20: I've replaced the get_activation function with a direct call to the dictionary, so we can pass arguments (like inplace=True) when we instantiate the classes, as was done before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, activation functions were hardcoded in the blocks.
Now they can be set via the configuration, allowing different models to use different activations without changing code.