Skip to content

Adding configs for downloading a sample dataset#69

Merged
IFenton merged 30 commits intomainfrom
41-download-notebook-data
Sep 18, 2025
Merged

Adding configs for downloading a sample dataset#69
IFenton merged 30 commits intomainfrom
41-download-notebook-data

Conversation

@IFenton
Copy link
Copy Markdown
Contributor

@IFenton IFenton commented Aug 20, 2025

This will cover 2020-01-01 to 2020-01-04 and download the full list of relevant variables, including those used in IceNet. It will become the default dataset downloaded when running the code

@IFenton
Copy link
Copy Markdown
Contributor Author

IFenton commented Aug 20, 2025

Closes #41

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 20, 2025

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  ice_station_zebra/data_processors
  cli.py 21-24
  zebra_data_processor_factory.py 26
  ice_station_zebra/data_processors/filters
  __init__.py 8
  doubling_filter.py 16-17, 21-22
  ice_station_zebra/data_processors/preprocessors
  __init__.py
  icenet_sic.py 33-36, 41-45
  ipreprocessor.py 10-11
  null.py 9
Project Total  

This report was generated by python-coverage-comment-action

@jemrobinson
Copy link
Copy Markdown
Member

jemrobinson commented Aug 21, 2025

We should make sure that our config names match the dataset names which should (ideally) meet the Anemoi naming conventions.

Our YAML file names should replace - with _ but otherwise be the same as the dataset they create.

I think purpose can be where we put [sample, full, whatever else] as you've done here.

@IFenton
Copy link
Copy Markdown
Contributor Author

IFenton commented Aug 27, 2025

We should make sure that our config names match the dataset names which should (ideally) meet the Anemoi naming conventions.

Done in 39f7bb8

@IFenton IFenton changed the title Adding configs for downloading a sample dataset [WIP] Adding configs for downloading a sample dataset Sep 3, 2025
@IFenton IFenton marked this pull request as ready for review September 12, 2025 16:37
@IFenton IFenton changed the title [WIP] Adding configs for downloading a sample dataset Adding configs for downloading a sample dataset Sep 12, 2025
@IFenton IFenton requested review from a team and jemrobinson September 12, 2025 16:37
@review-notebook-app
Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@jemrobinson
Copy link
Copy Markdown
Member

👀 Reviewing now

@jemrobinson jemrobinson force-pushed the 41-download-notebook-data branch from 79b77ce to 43e58a5 Compare September 18, 2025 16:13
Copy link
Copy Markdown
Member

@jemrobinson jemrobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IFenton IFenton merged commit f6465ee into main Sep 18, 2025
3 checks passed
@IFenton IFenton deleted the 41-download-notebook-data branch September 18, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants