Add EMA callback#74
Merged
jemrobinson merged 6 commits intomainfrom Aug 22, 2025
Merged
Conversation
…orch-lightning 2.5.4
…aging callback but has a simpler configuration interface
b58595c to
2924ac7
Compare
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||
erinuclkwon
approved these changes
Aug 22, 2025
Contributor
erinuclkwon
left a comment
There was a problem hiding this comment.
Yes, it does. LGTM. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@marianovitasari20 @erinuclkwon here's a small wrapper class to implement EMA using the callback that will be included in the next version of
pytorch-lightning. You can setdecay_rateplusevery_n_epochsandevery_n_stepswhich control how often the EMA averaging will be applied.I've added this as one of our default callbacks for training, so it will be applied to every model by default. It should remove the need for you to call an
EMAinstance inside your training loop. Does that do everything you need?Closes #75