Add quotes in Dockerfile cmd line#78
Closed
craddm wants to merge 1 commit intoalan-turing-institute:mainfrom
Closed
Add quotes in Dockerfile cmd line#78craddm wants to merge 1 commit intoalan-turing-institute:mainfrom
craddm wants to merge 1 commit intoalan-turing-institute:mainfrom
Conversation
Contributor
Author
|
Don't think so - what would count as dangerous? |
Member
|
Anything that the shell might interpret as a command like |
Contributor
Author
|
Hm, I'm not actually able to reproduce the problem locally (via the |
Member
|
Using the same password that fails in the deployment? Maybe this isn't the problem. |
Contributor
Author
|
Actually, I think you're right and I jumped the gun. The issue appears to be that somehow the admin password variable is empty, suggesting a deployment problem rather than something with this container. Closing this PR and the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds quotes around environment variables in the Dockerfile to prevent special characters from causing the healthcheck to faile
Closes #77