Fix for tooltip variable usage #32
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalgm
added a commit
to michalgm/radar-chart-d3
that referenced
this pull request
Aug 6, 2015
* Use d3.mouse to set tooltip coordinates offset to container * Bind tooltip node creation to .enter() selection so elements aren't added in every radar() call * localize tooltip variable - (as in alangrafu#32) * Add 10px offset to tooltips to avoid pointer collision * Reorder layers to ensure they are in proper order
This was referenced Aug 6, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tooltips are not rendered correctly because there are multiple problems with the tooltip variable:
This PR does a small correction in setTooltip, there is also another issue inside that function (the y variable in src/radar-chart.js@38 is declared global by mistake :(
I would recommend to add jshint to catch those errors, and to enclose RadarChart with a function to 'use strict' and avoid those hard to find problems. I'll do it in a future PR, however the change is not so small and merging will require more eyes.