Issue72 Deprecate Add<T> method in favor of Set<T>#136
Open
matthew-p wants to merge 6 commits intoalastairtree:masterfrom
Open
Issue72 Deprecate Add<T> method in favor of Set<T>#136matthew-p wants to merge 6 commits intoalastairtree:masterfrom
matthew-p wants to merge 6 commits intoalastairtree:masterfrom
Conversation
alastairtree
approved these changes
Sep 27, 2020
Owner
alastairtree
left a comment
There was a problem hiding this comment.
This looks great, thank you. Will leave this here until i have setup a branch for the 3.0 changes. Thanks!
Contributor
|
Tip: |
Owner
Did not know that, very useful! Let's use it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An attempt to address issue # 72, deprecating the IAppCache.Add(...) method with a .Set() method
Replaces the functionality as-is, adds [Obsolete] attributes to the Add method, and a unit test to confirm that all classes implementing IAppCache have an Obsolete attribute on their Add method
#72