Repository navigation
fix: serve sidebars from shared assets - #379
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: ae3dba2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #379 +/- ##
==========================================
+ Coverage 69.12% 69.45% +0.32%
==========================================
Files 102 104 +2
Lines 3964 4000 +36
Branches 1184 1196 +12
==========================================
+ Hits 2740 2778 +38
+ Misses 975 973 -2
Partials 249 249 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
Better contribute/implement on upstream |
github-actions Bot
pushed a commit
that referenced
this pull request
Nov 14, 2026
* fix: serve sidebars from shared assets * fix: preserve sidebar layout and active navigation * test: cover shared sidebar plugin lifecycle
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated documentation pages now load navigation from a shared content-hashed JSON asset instead of embedding the complete sidebar in every HTML file. A small manifest is fetched without caching and points to the immutable payload. Existing documentation repositories need no configuration changes.
The theme preserves the original three-column layout and sidebar controls, expands the active page's ancestors, and keeps breadcrumbs, search and previous/next navigation. Server-rendered document content remains readable with JavaScript disabled. The main script uses a stable URL so a sidebar title change does not rename the script reference in every HTML page.
Measurements use the same
acp-docsrelease-4.5 commit6bae4f1dc33c4ff038ed71a5ec3536da0276fb0cand identical local site definitions. The baseline is Doom9322691b52587ef0132486d4be324a946eaa3516; this branch isae3dba252bebd5b00e10a7789ee2dd37c57fec6b.The shared sidebar is 194,972 bytes plus a 92-byte manifest. The remaining title-edit changes include six HTML pages, four Markdown/text outputs and eight web assets.
Validation:
yarn build,yarn testandyarn docs:buildpass; 72 test files and 816 tests pass.yarn lintpasses with 0 errors and 3 warnings.yarn typecovpasses at 41,930/41,930 (100%); the threshold remains 100%.yarn docs:exportremains not verifiable on this machine because its isolated HOME lacks the Playwright Chromium executable. The pull request's CI covers PDF export.This release-4.5 input contains English pages only. Chinese/Russian rendering and version/language switching cannot be verified against this single-language, single-version input.