Add feature to disable fact generation shell script #235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add feature to disable fact generation shell script --------- Co-authored-by: Tanguy Van Acker <[email protected]>
|
@ssanderr this seems to have two drivers. One to disable the fact generation script and one to fix the environment it uploads to. I'm happy fixing the environment side and will take a look at the options there. I'm not convinced of the use case for disabling the fact generation script though. Can you give me more details? |
albatrossflavour
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
puppet facts uploadused in the fact generation script is able to unintentionally overwrite the environment fact. This adds a feature flag to disable the fact generation shell script. If this script is disabled, the relevant facts will now be resolved within the Facter script itself. This primarily affects the facts generated by package management tools.