Fact upload not working correctly for windows due to path is NIX specific #237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ific. Added windows executable path
Error on windows:
Error: /Stage[main]/Os_patching/Exec[os_patching::exec::fact_upload]: Failed to call refresh: Could not find command '/opt/puppetlabs/bin/puppet'
Error: /Stage[main]/Os_patching/Exec[os_patching::exec::fact_upload]: Could not find command '/opt/puppetlabs/bin/puppet'
Now working correctly for windows as well:
Info: /Stage[main]/Os_patching/File[C:/ProgramData/os_patching]: Scheduling refresh of Exec[os_patching::exec::fact_upload]
Notice: /Stage[main]/Os_patching/File[C:/ProgramData/os_patching/os_patching_fact_generation.ps1]/ensure: defined content as '{sha256}6baedcd3b32bb3359fd20ba9942def3ed595a6205c4b07daa8bf290fcc79efd9' (corrective)
Info: /Stage[main]/Os_patching/File[C:/ProgramData/os_patching/os_patching_fact_generation.ps1]: Scheduling refresh of Exec[os_patching::exec::fact]
Info: /Stage[main]/Os_patching/File[C:/ProgramData/os_patching/os_patching_fact_generation.ps1]: Scheduling refresh of Exec[os_patching::exec::fact_upload]
Notice: /Stage[main]/Os_patching/File[C:/ProgramData/os_patching/patch_window]/ensure: defined content as '{sha256}bcbe4af70688633b6d8d5e6e16647e486e7edc2db12e67f679d4a09a76fd7fab' (corrective)
Info: /Stage[main]/Os_patching/File[C:/ProgramData/os_patching/patch_window]: Scheduling refresh of Exec[os_patching::exec::fact_upload]
Notice: /Stage[main]/Os_patching/File[C:/ProgramData/os_patching/reboot_override]/ensure: defined content as '{sha256}37a8eec1ce19687d132fe29051dca629d164e2c4958ba141d5f4133a33f0688f' (corrective)
Info: /Stage[main]/Os_patching/File[C:/ProgramData/os_patching/reboot_override]: Scheduling refresh of Exec[os_patching::exec::fact_upload]
Notice: /Stage[main]/Os_patching/Exec[os_patching::exec::fact_upload]: Triggered 'refresh' from 4 events
Notice: /Stage[main]/Os_patching/Exec[os_patching::exec::fact]: Triggered 'refresh' from 1 event
Fact upload not working correctly for windows due to path is NIX spec…
|
Can this be closed? @albatrossflavour |
|
Hi @ChristianTrab , thanks for the PR and apologies for the delay. The module hiera should take care of that. It looks up the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ific. Added windows executable path
Error on windows:
Error: /Stage[main]/Os_patching/Exec[os_patching::exec::fact_upload]: Failed to call refresh: Could not find command '/opt/puppetlabs/bin/puppet'
Error: /Stage[main]/Os_patching/Exec[os_patching::exec::fact_upload]: Could not find command '/opt/puppetlabs/bin/puppet'
Now working correctly for windows as well:
Info: /Stage[main]/Os_patching/File[C:/ProgramData/os_patching]: Scheduling refresh of Exec[os_patching::exec::fact_upload]
Notice: /Stage[main]/Os_patching/File[C:/ProgramData/os_patching/os_patching_fact_generation.ps1]/ensure: defined content as '{sha256}6baedcd3b32bb3359fd20ba9942def3ed595a6205c4b07daa8bf290fcc79efd9' (corrective)
Info: /Stage[main]/Os_patching/File[C:/ProgramData/os_patching/os_patching_fact_generation.ps1]: Scheduling refresh of Exec[os_patching::exec::fact]
Info: /Stage[main]/Os_patching/File[C:/ProgramData/os_patching/os_patching_fact_generation.ps1]: Scheduling refresh of Exec[os_patching::exec::fact_upload]
Notice: /Stage[main]/Os_patching/File[C:/ProgramData/os_patching/patch_window]/ensure: defined content as '{sha256}bcbe4af70688633b6d8d5e6e16647e486e7edc2db12e67f679d4a09a76fd7fab' (corrective)
Info: /Stage[main]/Os_patching/File[C:/ProgramData/os_patching/patch_window]: Scheduling refresh of Exec[os_patching::exec::fact_upload]
Notice: /Stage[main]/Os_patching/File[C:/ProgramData/os_patching/reboot_override]/ensure: defined content as '{sha256}37a8eec1ce19687d132fe29051dca629d164e2c4958ba141d5f4133a33f0688f' (corrective)
Info: /Stage[main]/Os_patching/File[C:/ProgramData/os_patching/reboot_override]: Scheduling refresh of Exec[os_patching::exec::fact_upload]
Notice: /Stage[main]/Os_patching/Exec[os_patching::exec::fact_upload]: Triggered 'refresh' from 4 events
Notice: /Stage[main]/Os_patching/Exec[os_patching::exec::fact]: Triggered 'refresh' from 1 event