F preflight setup check#2
Open
albin-paul-saju wants to merge 6 commits intomainfrom
Open
Conversation
- Add preflight module that detects standalone `agent` CLI or falls back to `cursor agent`, and enforces Node >=18 - Update AI Review setup and orchestrator to use preflight validation - Use process.execPath for MCP server to ensure Node >=18 - Add unit tests for preflight logic with dependency injection - Update README with AI Review setup instructions Made-with: Cursor
albin-paul-saju
force-pushed
the
f-preflight-setup-check
branch
from
2db7675 to
964b820
Compare
- Refactor resolvePrerequisites() to return a PrerequisiteResult object and throw on failure instead of returning null - Add UserCancelledError (following vscode-azext-utils pattern) to distinguish user cancellation from real errors - Wrap enableAiReview() in top-level try/catch: silently swallow cancellations, show error notification for actual failures - In reviewOrchestrator doReview(), prompt user to run "Enable AI Review" when preflight fails instead of throwing Made-with: Cursor
Use spawn-based login detection that reads stdout immediately (handles the hanging `agent status` command), check for login before MCP setup, and replace modal dialogs with persistent notification-based prompts for Node upgrade, CLI install, and agent login flows. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.