Update CI workflow to use setup-uv for Python setup#35
Merged
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the CI workflow to use astral-sh/setup-uv for Python setup and dependency installation, simplifying steps and relying on uv-managed environments. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider pinning an explicit
uv-versioninastral-sh/setup-uv@v5to avoid unexpected CI breakages from future uv releases. - Now that
uvmanages the environment and you’ve dropped--system, double-check that any tools invoked later in the workflow (likepre-commit) are expected to come from the activated uv environment and not from a system/global install; if not, you may want to make that assumption explicit in the workflow name or comments.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider pinning an explicit `uv-version` in `astral-sh/setup-uv@v5` to avoid unexpected CI breakages from future uv releases.
- Now that `uv` manages the environment and you’ve dropped `--system`, double-check that any tools invoked later in the workflow (like `pre-commit`) are expected to come from the activated uv environment and not from a system/global install; if not, you may want to make that assumption explicit in the workflow name or comments.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Pull request overview
This PR modernizes the CI workflow by replacing the traditional Python setup process with the astral-sh/setup-uv action, streamlining dependency installation and reducing workflow complexity.
Changes:
- Replaced
actions/setup-python@v5withastral-sh/setup-uv@v5for Python environment setup - Removed manual
pip install --upgrade uvstep by using the dedicated setup-uv action - Simplified dependency installation command by removing the
--systemflag and using virtual environment management - Cleaned up workflow syntax by converting multi-line run commands to single-line commands where appropriate
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Thanks! This is a good. Faster CI is always a bliss. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the CI workflow to use the
astral-sh/setup-uvaction for setting up Python environments and installing dependencies, streamlining the process and removing redundant steps.CI workflow improvements:
actions/setup-pythonaction withastral-sh/setup-uvto set up Python and manage environments more efficiently (.github/workflows/ci.yml).uv pip install -r requirements-dev.txtdirectly (.github/workflows/ci.yml).cc: @ternaus
Summary by Sourcery
Update the CI workflow to use uv for Python setup and dependency installation.
CI: