Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tracing added for imply and open telemetry #1424

Merged
merged 31 commits into from
Apr 2, 2025
Merged

Conversation

Blu-J
Copy link
Collaborator

@Blu-J Blu-J commented Mar 7, 2025

Pull Request Checklist


PR-Codex overview

This PR primarily focuses on updating the documentation and code to improve consistency in parameter naming, specifically changing instances of client to client_. It also introduces new tracing functionalities and updates client handling in various methods.

Detailed summary

  • Changed parameter name client to client_ in multiple .mdx files and TypeScript files.
  • Added new tracing functionalities in TraceHeader class and related methods.
  • Updated documentation for TraceHeader methods.
  • Enhanced header tracking in client methods.
  • Improved error handling and client tracking in various smart account actions.

The following files were skipped due to too many changes: yarn.lock

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Mar 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aa-sdk-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 1, 2025 9:13pm
aa-sdk-ui-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 1, 2025 9:13pm

Copy link

graphite-app bot commented Mar 7, 2025

How to use the Graphite Merge Queue

Add the label graphite-merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@Blu-J Blu-J changed the title Jade/wip/tracing sdk Tracing For Imply and Others Mar 11, 2025
@Blu-J Blu-J changed the title Tracing For Imply and Others feat: tracing added for imply and open telemetry Mar 11, 2025
Copy link
Collaborator

@moldy530 moldy530 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great, there might be one case to check here though. So we initially added the headers on all clients. However, we ended up having to do it just on alchemy clients because adding headers was causing issues for someone who was using aa-sdk core to call a different RPC provider. that RPC provider was throwing errors due to unknown headers or extra headers being added

@Blu-J Blu-J force-pushed the jade/wip/tracing-sdk branch from 955646d to 2877b9f Compare March 31, 2025 20:03
moldy530
moldy530 previously approved these changes Apr 1, 2025
@Blu-J Blu-J merged commit 1caf63b into main Apr 2, 2025
7 checks passed
@Blu-J Blu-J deleted the jade/wip/tracing-sdk branch April 2, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants