This repository was archived by the owner on Oct 11, 2024. It is now read-only.
Rename variable holding protected resource info #4451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current Aviator status
This pull request is currently open (not queued). How to mergeTo merge this PR, comment |
pandeyabs
approved these changes
Oct 9, 2023
Rename backup model variables that holds the protected resource ID and name. The variable name has changed from ResourceOwner[ID|Name] to ProtectedResource[ID|Name]. The previous version of the variable in the model of the form ProtectedResourceX wasn't getting populated and never had any data persisted for it even though other code sometimes relied on it having a value. The current update ** DOES NOT ** change the JSON tag associated with the renamed variable. This means that golang's stdlib JSON serialization with continue to use the old name. Thus there's no need for additional code to handle previously serialized backup models.
ashmrtn
force-pushed
the
backup-field-rename
branch
from
370776f to
333cd58
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename backup model variables that holds the protected resource ID and name. The variable name has changed from ResourceOwner[ID|Name] to ProtectedResource[ID|Name].
The previous version of the variable in the model of the form ProtectedResourceX wasn't getting populated in any release from when it was added until main and never had any data persisted for it even though other code sometimes relied on it having a value.
The current update ** DOES NOT ** change the JSON tag associated with the renamed variable. This means that golang's stdlib JSON serialization with continue to use the old name. Thus there's no need for additional code to handle previously serialized backup models.
Manually tested backup list command with OneDrive/Exchange and successfully got the resource owner field in the output
Does this PR need a docs update or release note?
Type of change
Test Plan