Skip to content
This repository was archived by the owner on Oct 11, 2024. It is now read-only.

Rename variable holding protected resource info #4451

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ashmrtn
Copy link
Contributor

@ashmrtn ashmrtn commented Oct 6, 2023

Rename backup model variables that holds the protected resource ID and name. The variable name has changed from ResourceOwner[ID|Name] to ProtectedResource[ID|Name].

The previous version of the variable in the model of the form ProtectedResourceX wasn't getting populated in any release from when it was added until main and never had any data persisted for it even though other code sometimes relied on it having a value.

The current update ** DOES NOT ** change the JSON tag associated with the renamed variable. This means that golang's stdlib JSON serialization with continue to use the old name. Thus there's no need for additional code to handle previously serialized backup models.

Manually tested backup list command with OneDrive/Exchange and successfully got the resource owner field in the output


Does this PR need a docs update or release note?

  • ✅ Yes, it's included
  • 🕐 Yes, but in a later PR
  • ⛔ No

Type of change

  • 🌻 Feature
  • 🐛 Bugfix
  • 🗺️ Documentation
  • 🤖 Supportability/Tests
  • 💻 CI/Deployment
  • 🧹 Tech Debt/Cleanup

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@ashmrtn ashmrtn requested a review from a team October 6, 2023 22:38
@ashmrtn ashmrtn self-assigned this Oct 6, 2023
@aviator-app
Copy link
Contributor

aviator-app bot commented Oct 6, 2023

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This pull request is currently open (not queued).

How to merge

To merge this PR, comment /aviator merge or add the mergequeue label.


See the real-time status of this PR on the Aviator webapp.

@ashmrtn ashmrtn temporarily deployed to Testing October 6, 2023 22:38 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing October 6, 2023 22:38 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing October 6, 2023 22:38 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing October 6, 2023 22:38 — with GitHub Actions Inactive
Rename backup model variables that holds the protected resource ID and
name. The variable name has changed from ResourceOwner[ID|Name] to
ProtectedResource[ID|Name].

The previous version of the variable in the model of the form
ProtectedResourceX wasn't getting populated and never had any data
persisted for it even though other code sometimes relied on it having a
value.

The current update ** DOES NOT ** change the JSON tag associated with
the renamed variable. This means that golang's stdlib JSON serialization
with continue to use the old name. Thus there's no need for additional
code to handle previously serialized backup models.
@ashmrtn ashmrtn force-pushed the backup-field-rename branch from 370776f to 333cd58 Compare October 9, 2023 19:34
@ashmrtn ashmrtn temporarily deployed to Testing October 9, 2023 19:34 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing October 9, 2023 19:34 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing October 9, 2023 19:34 — with GitHub Actions Inactive
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ashmrtn ashmrtn temporarily deployed to Testing October 9, 2023 19:35 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing October 9, 2023 19:35 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing October 9, 2023 19:35 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing October 9, 2023 19:35 — with GitHub Actions Inactive
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants