Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions kong_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -718,6 +718,22 @@ func TestMapFlagWithSliceValue(t *testing.T) {
assert.Equal(t, map[string][]int{"a": {1, 2}, "b": {3}}, cli.Set)
}

func TestMapFlagWithUnmappableValueType(t *testing.T) {
var cli struct {
Set map[string]any
}
_, err := mustNew(t, &cli).Parse([]string{"--set", "a=b"})
assert.EqualError(t, err, "--set: no mapper for value type of map[string]interface {}")
}

func TestMapFlagWithUnmappableKeyType(t *testing.T) {
var cli struct {
Set map[complex128]string
}
_, err := mustNew(t, &cli).Parse([]string{"--set", "a=b"})
assert.EqualError(t, err, "--set: no mapper for key type of map[complex128]string")
}

type embeddedFlags struct {
Embedded string
}
Expand Down
6 changes: 6 additions & 0 deletions mapper.go
Original file line number Diff line number Diff line change
Expand Up @@ -515,13 +515,19 @@ func mapDecoder(r *Registry) MapperFunc {

keyScanner := ScanAsType(FlagValueToken, key)
keyDecoder := r.ForNamedType(keyTypeName, el.Key())
if keyDecoder == nil {
return fmt.Errorf("no mapper for key type of %s", target.Type())
}
keyValue := reflect.New(el.Key()).Elem()
if err := keyDecoder.Decode(ctx.WithScanner(keyScanner), keyValue); err != nil {
return fmt.Errorf("invalid map key %q", key)
}

valueScanner := ScanAsType(FlagValueToken, value)
valueDecoder := r.ForNamedType(valueTypeName, el.Elem())
if valueDecoder == nil {
return fmt.Errorf("no mapper for value type of %s", target.Type())
}
valueValue := reflect.New(el.Elem()).Elem()
if err := valueDecoder.Decode(ctx.WithScanner(valueScanner), valueValue); err != nil {
return fmt.Errorf("invalid map value %q", value)
Expand Down