Repository navigation
perf: avoid per-token mapper slice allocation - #483
Merged
alecthomas merged 1 commit intoSep 16, 2026
Merged
Conversation
alecthomas
approved these changes
Sep 16, 2026
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #482.
The mapping lexer currently creates a temporary
combined []Mapperfor each token, appending the global & token-specific mapper slices. This PR changes it to iterate over those existing slices directly. The mapper order, error short-circuiting, original-token-type selection, and existing EOF behavior are covered by tests.Isolated mapping-wrapper benchmark on my machine, using an allocation-free lexer with one global and one token-specific identity mapper:
These are median results from 10 runs. This benchmark isolates mapper dispatch and is not intended to represent whole-parser performance.
All existing tests, the new focused tests, race tests, example tests, and the configured linter pass.