Repository navigation
parser: cap recursive production depth - #485
Open
team-humaki wants to merge 1 commit into
Open
team-humaki wants to merge 1 commit into
team-humaki wants to merge 1 commit into
Conversation
Deeply nested input overflowed the goroutine stack because strct.Parse had no nesting bound. Count productions and return a ParseError once MaxParseDepth is exceeded.
alecthomas
reviewed
Oct 2, 2026
| // MaxParseDepth limits recursive production nesting. Deeply nested input | ||
| // otherwise overflows the goroutine stack with a fatal error that recover | ||
| // cannot catch. Zero disables the limit. | ||
| MaxParseDepth = 1024 |
Owner
There was a problem hiding this comment.
I think this should be configurable through a parser option.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #480.
Deeply nested input (for example 300k nested parentheses) recurses through
strct.Parseuntil the goroutine stack overflows. That fatal error is not recoverable withrecover(), so the process dies.Count nested productions on
parseContextand return aParseErroronceMaxParseDepth(default 1024, 0 disables) is exceeded. Shallow input is unchanged.go test .green (TestMaxParseDepth).